Trinitycore: [3.3.5] Priest - Hymn of Hope

[Jildor]

Description:

ID - 64901 Hymn of Hope
Trigger spell (64904) Hymn of Hope. Chance = 101

ID - 64904 Hymn of Hope

Effect 0: Id 137 (SPELL_EFFECT_ENERGIZE_PCT)
BasePoints = 3
Targets (22, 30) (TARGET_SRC_CASTER, TARGET_UNIT_SRC_AREA_ALLY)
Radius (Id 23) 40,00

Effect 1: Id 6 (SPELL_EFFECT_APPLY_AURA)
BasePoints = 20
Targets (22, 30) (TARGET_SRC_CASTER, TARGET_UNIT_SRC_AREA_ALLY)
Aura Id 35 (SPELL_AURA_MOD_INCREASE_ENERGY), value = 20, misc = 0 (0), miscB = 0, periodic = 0
Radius (Id 23) 40,00

Possible cause?
https://github.com/TrinityCore/TrinityCore/commit/2a462e93093d177a0e0bedf3e94ac2cf4e66a3c3

Current behaviour:

When you use 64901 Hymn of Hope and gain aura 64904 Hymn of Hope, if you cancel 64904 Hymn of Hope, you still having the mana increased

Expected behaviour:

You should lost the mana increased.

Steps to reproduce the problem:

1. Reduce your mana (by example 1000/6000)
2. Cast 64901 Hymn of Hope
3. When you obtain 64904 Hymn of Hope, remove this aura and see how your mana still (then if you remove all ticks of 64904 Hymn of Hope, you are full restored the mana)

Branch(es): 3.3.5

TC rev. hash/commit: 4d654f548b29bf61552d9f90da8254ecea91b63e

TDB version: TDB335.63

Operating system: Debian

[Jildor]

it does not work @Eliminationzx

@Treeston Can you take a look here?

[ghost]

Let's ask @ariel- , because Treeston is quite busy studying at the start of a new semester.

[Aokromes]

like ariel- xd

[Jildor]

I was asking @Treeston because the commit that I think caused the problem is yours 😄

[Keader]

Mana should restore only If you have aura no ?

[Jildor]

The problem is when you get tick from spell 64901, you get 64904 and increase your min and max power %, then if you remove 64904, you lost max power increased but min power still increased, then you get another tick of 64901 and increased another time....remove and repeat... 😄

[ariel-]

Let's ask @ariel- , because Treeston is quite busy studying at the start of a new semester.

Studying too, that's why I've been quite inactive.

An AuraScript should do it (remove linked aura when removing the main one)

EDIT: linked commit is not the cause of this, probably never worked properly

[Treeston]

Current power should remain increased when a +%mana effect is removed (that's intentional).

Removing 64901 should remove 64904, I'd say. 64904 should not reapply after 64901 removal (64901 is what triggers 64904).

[Jildor]

No, @Treeston the problem is when you remove 64904, if you get another tick from 64901 and obtain another time 64904, then, you repeat this 5 times and full mana ;)

[ghost]

To be fair, Treeston is saying what it should be, while you said what is actually happening. That is both sides of the same issue, "Expected behaviour:" and "Current behaviour:", which your issue is all about.

[Treeston]

Removing the visible one (64904?) should remove the invisible one (64901?). Same behavior as Combustion after e07a322.

[Jildor]

I think affects nearby allys too, then, if the aura can't remove by right click, problem solved.

I don't know what is blizzlike here.

[Keader]

Nice bug btw
Maybe remove ENERGIZE_PCT if not removed by expire?

[Jildor]

seems the most coherent.

I vote for kill player if not removed by expire 😈

[Keader]

What you think about https://github.com/TrinityCore/TrinityCore/issues/20504#issuecomment-336735332 @Treeston ?

[Eliminationzx]

Same problem with SPELL_AURA_MOD_INCREASE_HEALTH, SPELL_AURA_MOD_INCREASE_HEALTH_2.
Check Commanding Shout.
I guess there is problem with saving old value hp/mana before applying increase auras.
After unapply it should set hp/mana to old value without modifiers from increase auras.