Trinitycore: [3.3.5] Beacon of Light wrong proc with Judgement of Light

[Keader]

Description: Spell Beacon of Light (53563) is proccing with Judgement of Light (20271) and making paladin overpower.

Current behaviour: If you cast Judgement of Light in 1 target, put Beacon of Light in some friend, everyonde that hit melee damage in target affected by your judgement will generate a Heal to your friend.

Expected behaviour: Beacon of Light should not proc with Judgement of Light.

Steps to reproduce the problem:

1. Put a paladin and other character in party.
2. Use Beacon of Light on you, and use Judgement of Light in some dummy.
3. Make other character attack by melee on dummy
4. You will see alot of heal come to you by Beacon of Light

Branch(es): 3.3.5

TC rev. hash/commit: 971ed856a49dc56ea33d9a0779b1386eea5cd3ca

[Jildor]

Then should add a check in this script to avoid proc?
https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/scripts/Spells/spell_paladin.cpp#L1706

P.D. You forgot the DB version 😄

[Aokromes]

irrelevant, db version was added to avoid ytdb people XD

[Keader]

Yes Jildor, will work but dont looks like correct.

[lachtanek]

Just check it with SpellFamilyFlags in spell_proc or make it not proc from triggered (but I think that breaks some other spell)

[Jildor]

I think happens too with Glyph of Holy Light

I think the cause is the AttributesMask, but if you remove PROC_ATTR_TRIGGERED_CAN_PROC:

UPDATE `spell_proc` SET `AttributesMask`=0 WHERE `SpellID`=53651;

By example break Holy Shock

[lachtanek]

If you want a quick fix just

UPDATE spell_proc SET SpellFamilyFlags0 = 4294967295, SpellFamilyFlags1 = 4294967294, SpellFamilyFlags2 = 4294967295 WHERE SpellId = 53651;

It may be better to change holy shock to not use triggered cast tho, it probably already has all the required flags to pass GCD checks and such anyway.

[TheWinchesters]

Any news?

[SoyTorete]

It seems that no and this is really important

[Keader]

Will be fixed by https://github.com/TrinityCore/TrinityCore/pull/21260
We just need wait ariel back :)

[Jildor]

come on @ariel- we need you 😘

[TheWinchesters]

I have just noticed that it also procs with Seal of Light (20165)