Trinitycore: Spawning missing creatures in Pandaria,Warlods of Draenor and Legion

[Daniel25]

Adding missing creatures spawns in maps 780,1116,1220.

• Master

last commit: https://github.com/TrinityCore/TrinityCore/commit/28ec50b0534c721e613d68b7b1daa73d573fbc17

file creatures:
file creature_template:
file creature_equip_template:
file creature_loot_template1:
file creature_loot_template2:
file creature_queststarter:
file creature_questender:
file creature_template_addon:
Uploaded in mega everything:
https://mega.nz/#!yVBzkDoK!PvfQKSShlwjtwAVIFH3JPaRgpiH1IA-yaJggQCxHogU

[Killyana]

Creature_addon missing.

[Kittnz]

Is this from a leveling sniff?

[Daniel25]

It isnt a leveling sniff. The most of creatures are there (except legion).
Timeless isle npcs are missing by the way.
I have only 36.338 creature_addon of that 123.000 spawns in my db. And I havent the sniffers now...
If the request isnt ok, no problem.

[HannibalRoG]

Most of npc in draenor and legion appear green (friendly) and with very low live.

[ArcaneFox]

I can fix the 1 hp and similar issues by parsing other sniffs.
If there is a chance to commit this I will start working on this.

Ofc we need to remove duplicated spawns (after commit?)...

[Daniel25]

Added creature_template_addon, creature_template, creature_queststarter, creature_questender and creature_loot_template for maps 870,1116,1220.
About duplicated spawns...strange....

[offl]

What happened to numbers after dots(PosX, PosY, PosZ, Orientation columns)? :)
```sql(@CGUID+78011,91565,1220,0,0,1,0,0,0,0,2198,2221,364,5,300,0,0,40962,0,0,0,0,0,23222),
(@CGUID+78012,91561,1220,0,0,1,0,0,0,0,2200,2222,364,2,300,0,0,40962,0,0,0,0,0,23222),
(@CGUID+78013,91561,1220,0,0,1,0,0,0,0,2217,2208,354,5,300,0,0,40962,0,0,0,0,0,23222),
(@CGUID+78014,91561,1220,0,0,1,0,0,0,0,2212,2205,356,3,300,0,0,40962,0,0,0,0,0,23222),
(@CGUID+78015,92367,1220,0,0,1,0,0,0,0,2204,2205,358,4,300,0,0,40962,0,0,0,0,0,23222),
(@CGUID+78016,91561,1220,0,0,1,0,0,0,0,2222,2210,353,0,300,0,0,40962,0,0,0,0,0,23222),

[HannibalRoG]

@ArcaneFox I have some sniff from draenor and pandarian, email me if you want the link to download.
It is sensitive information, because of that i dont want to public them.

[ArcaneFox]

I need some time to make a program for this. Once I finished it, I will post the updated sql here.

The program will fix the duplicated spawns (only the same position) and the missing values (like 1 hp).

@HannibalRoG I will need only the sql files. Currently, I have two different sources: MoP + MoP/Draenor/Legion. Both of them are leveling sniffs.

[ArcaneFox]

Removed 10247 duplicated spawn

creature.zip

[uroborusLogos]

Twilight Highlands Is not spawned.

[funjoker]

Duplicate spawns can indicate personal spawns or temporary spawns.
Just use INNER JOIN to find duplicate spawns.

[Daniel25]

What funjoker said. If then of adding the creature_template there are duplicated spawns so maybe we can delete them. Surely there are duplicated spawns because of quests spawns, phased creatures,etc...
I just wanted to share that spawns because noone is sharing it and that maps are empty... If it is causing more issues that other thing, so you can close the request and everything will be ok :).

[HannibalRoG]

From almost the last GUID in actual DB, started in 450014 used here https://github.com/TrinityCore/TrinityCore/pull/17021 plus 2500 GUID aproximately in that PR for map 860, i think GUID 453000 is a good number for this 112879 spawns.
I am rigth?

[HannibalRoG]

@ArcaneFox The problems of low life, level 1 and npc friendlys are maintained, even in your sql.
Another thing, due to the lack of information in the creature table the npc when you approach it fall from the sky.

[ArcaneFox]

@HannibalRoG Could you send me a wrong npc (or guid)?

[HannibalRoG]

@ArcaneFox .tele draenor where you appear all npc are wrong level and all green, one guid 501612

[ArcaneFox]

Yes, they are wrong without

• creature_template
• creature_equip_template
• creature_loot_template1
• creature_loot_template2
• creature_queststarter
• creature_questender
• creature_template_addon

but they are working with these sqls:

[HannibalRoG]

@ArcaneFox what sql did you apply, the one from daniel25 or yours with the duplicated spawn removed?

[HannibalRoG]

Problem solved, i was imported only your creature... LoL
btw most of creatures appear yelow that means neutral... do you know how to solve?

[ArcaneFox]

I don't know well the tables of TrinityCore, but if someone could tell me the possible bad values in the fields, then maybe I can fix them (or at least separate the wrong spawns to an another file).

[Daniel25]

neutral faction=7, you can check in wowhead the correct faction or in the dbc file. (I suposse that you have .gm off).

[HannibalRoG]

I dont use GM account for testing thinks like this, i use an account with level 0, and add with RBAC commands like .tele and .modify speed.
@ArcaneFox I think we should wait for the opinion of some of the TRINITY developers to know if these npc can be added to the official DB and not waste time with them.

[funjoker]

In the past there was the idea of accepting spawns only with phases and cleaned.
But since this is a fulltime job i guess this is kinda impossible

[Hellfurian]

@ArcaneFox Getting errors trying to import your sql file :| Unknown column 'xyz' in 'field list'?

Probably something wrong on my side.

[ArcaneFox]

I don't know what changes happened to the creature table, but you can fix/import the creatures.sql with the following steps.

1) Drop your "world" db
2) Import TDB 720.00 [optional: update to 2017-08-25]
3) Import the creatures.sql
4) Update your TDB
5) Export the imported creatures to a new file

[Aokromes]

he gets error because he tried to import it without adding real guid.

[Hellfurian]

@Aokromes you're right. I feel incredibly dumb now... Thank you both.

[LuigiElleBalotta]

Since master branch is not stable i think we should take spawns as they are from sniffs (it means... our situation is already a shit, we can't make it worst, so accepting unclean things could be better than not doing it, i'm going to explain this in this comment). And while scripting quests etc... we can fix phases, personal spawns etc.. removing things not needed and keeping things needed.. at least we poor dev without sniffs can have sufficient data to work with

[ArcaneFox]

I've been working on this since yesterday (finally my PC working again). Trainers, vendors, flight masters, other npcs with gossip menu are spawned. Every duplicated and moving creature has removed.

Someone know a method to separate pandaria/draenor/legion creatures?

[Killyana]

You can use entry plage, or map ID.

[ArcaneFox]

Separated 17513 moving creatures.

Need to test "creature (idle npcs).sql" and "creature (idle mobs).sql". I think this is good starting point to populate these 3 expansion.

v9.zip

[HannibalRoG]

Can anyone tell if this is valid?

[ArcaneFox]

There are still some multiple spawns (mainly Draenor & Legion). I used the sniffed creature_templates* to separate the moving and idling creatures.
(missing or wrong fields in the creature_template == wrong spawns)

*TrinityCore creature_template and Daniel25's creature_template

[Daniel25]

I guess that it wont be valid even if you work about it.So you can save it for your personal interest...

[Killyana]

If the spawns are cleaned they will pushed, keep on mind that cleaning existing spawns on the DB takes more time than re-spawning the whole stuff, it's the case for the DK starting area, raw spawns were pushed, and I started to clean the mess before November and still 50% of the work is not done.