Trinitycore: [3.3.5] Scripts/Ulduar: Kologarn's body falling off the map

Created on 11 Apr 2017  路  14Comments  路  Source: TrinityCore/TrinityCore

Description: After he dies, Kologarn's body should become a bridge. But in current revs, Kologarn's body falls off the map (tested in Ulduar 25 man)

image


Steps to reproduce the problem:

  1. go crea id 32930
  2. Kill kologarn

Branch(es): 3.3.5

TC rev. hash/commit: 21b2042840e05ebeba365c54d47c07c13fde123f

Branch-3.3.5a Comp-C++Script Sub-Instances Sub-MapMMapVmaps

Most helpful comment

Working on some more improvements for his fight, i'm taking too long, i know, sorry 馃樃

All 14 comments

I assume the bridge is in fact a gameobject summoned on its death, right?

Based in ulduar.h i think so
GO_KOLOGARN_BRIDGE = 194232,
i dont see where this object is summoned xd (when kologarn die)
hmm, in SetBossState has a HandleGameObject(KologarnBridgeGUID, false); that not working btw lol

But is is still wrong that Kologarn falls down on death. He needs a special case where he does not fall down, when he dies cuz he is floating above the ground. The bridge gets summoned but the corpse of Kologarn should remain in air.

This didn't happen few years ago :o

FIx:

UPDATE `creature_template` SET `InhabitType`=1 WHERE `entry` IN(32930,33909);
diff --git a/src/server/scripts/Northrend/Ulduar/Ulduar/boss_kologarn.cpp b/src/server/scripts/Northrend/Ulduar/Ulduar/boss_kologarn.cpp
index b17a534..96182cb 100644
--- a/src/server/scripts/Northrend/Ulduar/Ulduar/boss_kologarn.cpp
+++ b/src/server/scripts/Northrend/Ulduar/Ulduar/boss_kologarn.cpp
@@ -148,7 +148,6 @@ class boss_kologarn : public CreatureScript
             {
                 Talk(SAY_DEATH);
                 DoCast(SPELL_KOLOGARN_PACIFY);
-                me->GetMotionMaster()->MoveTargetedHome();
                 me->SetFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_NOT_SELECTABLE);
                 me->SetCorpseDelay(604800); // Prevent corpse from despawning.
                 _JustDied();

thanks sirikfoll.It is right now.

@sirikfoll : any chance that you could create a PR for that fix?

Or simply push fix :P

@Keader : do you want to do the honors, since this issue is your "baby" ? ;-)

@tkrokli I will talk with sirikfoll.
He will change more stuffs i think

@sirikfoll :P ^^

Working on some more improvements for his fight, i'm taking too long, i know, sorry 馃樃

Tested the skybridge. Seems to work fine doing it multiple times.

Cannot reproduce on rev. e4658a1307b1

Was this page helpful?
0 / 5 - 0 ratings

Related issues

cbcs picture cbcs  路  3Comments

ZenoX92 picture ZenoX92  路  3Comments

chilito picture chilito  路  3Comments

Keader picture Keader  路  3Comments

jerbookins picture jerbookins  路  3Comments