Trinitycore: command modify faction crash

[Farrarie]

Description:
the command modify faction crash the world server
Current behaviour: (Tell us what happens.)
when I change a faction of an npc when I type .mod fac 1 to an npc mob the world server crash
Expected behaviour: (Tell us what should happen instead.)
when I type .mod fac 1 to npc the faction change without crashing the world server
Steps to reproduce the problem:

1. type .mod faction to an npc
2. it change the npc faction
3. dont crash the world server

Branch(es): 3.3.5 / master (Tell us which branch(es) this issue affects.)
master
TC rev. hash/commit:
8aacc07
TDB version:
703.00 and latest I keep all uptodate 2017_02_13
Operating system:
windows 10 64-bit

[DDuarte]

When you created this issue, there was a line already in the issue description that says "(If this is a crash report, include the crashlog with https://gist.github.com/)". Why did you choose to ignore this information?

[Farrarie]

I dont know what you mean im a noob at github
when I click at your link it take me to a new page create a new gist ?

[DDuarte]

Fair enough.

When your server crashed, a .txt file in the Crashes folder got created.
Copy paste that crash log to a gist and write here the URL of the gist.

[Farrarie]

I created the gist

[DDuarte]

Good job, that's it.

However, that crash log is not very useful because the server was compiled in Release mode.
Compile the server in Debug mode and post the new crashlog (you will notice that it is much more complete).

[Farrarie]

thanks friend for trying to help
I do debug now

[Farrarie]

when I choose debug when compiling no world server or authserver their
========== Build: 20 succeeded, 6 failed, 0 up-to-date, 1 skipped ==========
and cant find error log or something in release mod its ok only in debug

[DDuarte]

The compile log has the source of the errors.

[Farrarie]

I will re do cmake maybe files got curropt

[Farrarie]

now debug give worldserver after re do cmake
I will do gist now

[Farrarie]

debug gist

[DDuarte]

Much better.

Please post the result of the World DB query:

SELECT * FROM `trinity_string` WHERE `ID`=130;

[Farrarie]

sql error (1054) Unkown colunm ID in Where cluase I cloesed it by wrong
I dont now how to reopen the post

[DDuarte]

My mistake, fixed query:

SELECT * FROM `trinity_string` WHERE `entry`=130;

[Farrarie]

now it close the world server
I will use debug world server
and post gist

[Farrarie]

it crash debuged world server
here is the crash.txt

[DDuarte]

Result of the query

SELECT * FROM `trinity_string` WHERE `entry`=130;

??

[Farrarie]

I did it still after I did the query
the world server still crash

[DDuarte]

It's a SELECT, I want to know the result of it. It does not change anything.

[Farrarie]

You changed GUID=%i's Faction to %i, flags to %i, npcflag to %i, dynflag to %i.
is this what you want ?

[DDuarte]

That confirms the crash. Fix will be done soon.

[Farrarie]

thanks alot good friend

[DDuarte]

Fix:

UPDATE `trinity_string` SET `content_default`='You changed GUID=%s\'s Faction to %i, flags to %i, npcflag to %i, dynflag to %i.' WHERE `entry`=130;

[Farrarie]

it work thanks alot good friend

[Rochet2]

https://github.com/TrinityCore/TrinityCore/pull/18863
related PR that was going to fix this.

[DDuarte]

Let's use that then, thanks