Trinitycore: [3.3.5] Core/Spells: non-physical weapon damage does not trigger
Description: If you for example create a custom weapon (for testing), and give it 1-1 physical damage and like 100 holy damage like i did here: http://puu.sh/tV7Rc/62af0ad9ee.png
Ingame it only deals the physical damage, the holy damage doesnt apply at all. Is there something i am misunderstanding about the concept?
Current behaviour: (Tell us what happens.) The other weapon damage doesnt seem to apply.
Expected behaviour: (Tell us what should happen instead.) The holy damage should apply, i guess :P
Steps to reproduce the problem:
- Pick or create a weapon with other forms of damage than physical
- attack anything
- other weapon damage doesnt apply
Branch(es): 3.3.5 / master (Tell us which branch(es) this issue affects.) 3.3.5
TC rev. hash/commit: https://github.com/TrinityCore/TrinityCore/commit/09cc6b3c33cbe7becfbeb47846253da5febfc5e6
TDB version: 62
Operating system: ubuntu 14.04
VincentVanclef
All 13 comments
Custom items are not supported here in the TrinityCore issue tracker. Only issues with standard in-game items and spells are supported. Your issue belongs in the TrinityCore Forum pages, please post there:
ghost
on 9 Feb 2017
TL;DR: dmg2 is not implemented, except for feral bonus calculation for druids and sending it to client for tooltips.
I tried checking and seems to be the same thing with Ashbringer for example (13262) and Cobalt crusher (7730).
The dmg2 is ignored but dmg1 looks to work fine (for example with wands like Red Death (34146).
Tested on https://github.com/TrinityCore/TrinityCore/commit/02633a332cf730984d17f422f0571458676e3604
When testing I hit stuff and only physical damage was done amounting roughly to the dmg1 and when tested by lowering dmg1 to 1 only 1-2 damage was done ignoring the dmg2,
Infact when looking for DamageType in core it looks like it is only sent to client for dmg2 but never used otherwise.
Only dmg1 has the damage type used as seen in Spell::Spell: pItem->GetTemplate()->Damage[0].DamageType
Looking in core the dmg2 is only applied to feral bonus for druids through it being calculated into DPS which affects the bonus.
Rochet2
on 9 Feb 2017
Hmm, item http://www.wowhead.com/item=13262/ashbringer (http://wotlk.openwow.com/item=13262) does not seem to be available to players, maybe that's why it is not fixed? But if you have tested using http://www.wowhead.com/item=7730/cobalt-crusher (http://wotlk.openwow.com/item=7730) on straight source, could the issue be common to all those items (unless each item needs specific scripting or spell modifications)? Let's see if someone else knows more about it.
ghost
on 9 Feb 2017
@tkrokli I only added the custom item to test thats all. And yeah as Rochet2 says, the damage is definitely ignored by the core or client so someting is broken in the core for sure
VincentVanclef
on 9 Feb 2017
OK, let's just wait and see if ariel- or someone else has time to share some light on this issue.
ghost
on 9 Feb 2017
Chances are high miss and resist weapon ,In this issue is seen
confirm : 8d2f2f8f0603608f0f21e656046cb7ffcb4813a2
DeActiver
on 11 Feb 2017
OK, let's just wait and see if ariel- or someone else has time to share some light on this issue.
Rochet2 is right, damage2 is not implemented. We need sniffs from 3.3 patch era, as multiple damage types per weapon seems to be deprecated in Cataclysm
ariel-
on 19 Feb 2017
Here is a list of affected items that have dmg2 in use and are available to players through the loot tables (there can be quest rewards etc as well so this may not be a complete list): 936, 1318, 1482, 1959, 3194, 4446, 7682, 7730, 13952, 16039
Used the following SQL to get them:
select * from (
SELECT `item` FROM `creature_loot_template` WHERE `Reference` = 0 UNION
SELECT `item` FROM `disenchant_loot_template` WHERE `Reference` = 0 UNION
SELECT `item` FROM `fishing_loot_template` WHERE `Reference` = 0 UNION
SELECT `item` FROM `gameobject_loot_template` WHERE `Reference` = 0 UNION
SELECT `item` FROM `item_loot_template` WHERE `Reference` = 0 UNION
SELECT `item` FROM `milling_loot_template` WHERE `Reference` = 0 UNION
SELECT `item` FROM `pickpocketing_loot_template` WHERE `Reference` = 0 UNION
SELECT `item` FROM `prospecting_loot_template` WHERE `Reference` = 0 UNION
SELECT `item` FROM `reference_loot_template` WHERE `Reference` = 0 UNION
SELECT `item` FROM `skinning_loot_template` WHERE `Reference` = 0 UNION
SELECT `item` FROM `spell_loot_template` WHERE `Reference` = 0)
AS a where item in(select entry from item_template where dmg_max2 <> 0)
Also I guess its worth to note that dmg1 non-physical seems to be only implemented for wands. I think this is because in DB there are really only wands that use non-physical damage for primary damage.
Rochet2
on 19 Feb 2017
SELECT * FROM `item_template` WHERE `entry` IN (936,1318,1482,1959,3194,4446,7682,7730,13952,16039);
entry class subclass SoundOverrideSubclass name displayid Quality Flags FlagsExtra BuyCount BuyPrice SellPrice InventoryType AllowableClass AllowableRace ItemLevel RequiredLevel RequiredSkill RequiredSkillRank requiredspell requiredhonorrank RequiredCityRank RequiredReputationFaction RequiredReputationRank maxcount stackable ContainerSlots StatsCount stat_type1 stat_value1 stat_type2 stat_value2 stat_type3 stat_value3 stat_type4 stat_value4 stat_type5 stat_value5 stat_type6 stat_value6 stat_type7 stat_value7 stat_type8 stat_value8 stat_type9 stat_value9 stat_type10 stat_value10 ScalingStatDistribution ScalingStatValue dmg_min1 dmg_max1 dmg_type1 dmg_min2 dmg_max2 dmg_type2 armor holy_res fire_res nature_res frost_res shadow_res arcane_res delay ammo_type RangedModRange spellid_1 spelltrigger_1 spellcharges_1 spellppmRate_1 spellcooldown_1 spellcategory_1 spellcategorycooldown_1 spellid_2 spelltrigger_2 spellcharges_2 spellppmRate_2 spellcooldown_2 spellcategory_2 spellcategorycooldown_2 spellid_3 spelltrigger_3 spellcharges_3 spellppmRate_3 spellcooldown_3 spellcategory_3 spellcategorycooldown_3 spellid_4 spelltrigger_4 spellcharges_4 spellppmRate_4 spellcooldown_4 spellcategory_4 spellcategorycooldown_4 spellid_5 spelltrigger_5 spellcharges_5 spellppmRate_5 spellcooldown_5 spellcategory_5 spellcategorycooldown_5 bonding description PageText LanguageID PageMaterial startquest lockid Material sheath RandomProperty RandomSuffix block itemset MaxDurability area Map BagFamily TotemCategory socketColor_1 socketContent_1 socketColor_2 socketContent_2 socketColor_3 socketContent_3 socketBonus GemProperties RequiredDisenchantSkill ArmorDamageModifier duration ItemLimitCategory HolidayId ScriptName DisenchantID FoodType minMoneyLoot maxMoneyLoot flagsCustom VerifiedBuild
----- ------ -------- --------------------- --------------------- --------- ------- ------ ---------- -------- -------- --------- ------------- -------------- ------------- --------- ------------- ------------- ----------------- ------------- ----------------- ---------------- ------------------------- ---------------------- -------- --------- -------------- ---------- ---------- ----------- ---------- ----------- ---------- ----------- ---------- ----------- ---------- ----------- ---------- ----------- ---------- ----------- ---------- ----------- ---------- ----------- ----------- ------------ ----------------------- ---------------- -------- -------- --------- -------- -------- --------- ------ -------- -------- ---------- --------- ---------- ---------- ------ --------- -------------- --------- -------------- -------------- -------------- --------------- --------------- ----------------------- --------- -------------- -------------- -------------- --------------- --------------- ----------------------- --------- -------------- -------------- -------------- --------------- --------------- ----------------------- --------- -------------- -------------- -------------- --------------- --------------- ----------------------- --------- -------------- -------------- -------------- --------------- --------------- ----------------------- ------- ----------------------------- -------- ---------- ------------ ---------- ------ -------- ------ -------------- ------------ ------ ------- ------------- ------ ------ --------- ------------- ------------- --------------- ------------- --------------- ------------- --------------- ----------- ------------- ----------------------- ------------------- -------- ----------------- --------- ---------- ------------ -------- ------------ ------------ ----------- -------------
936 2 4 -1 Midnight Mace 5215 3 0 0 1 58104 11620 13 -1 -1 38 33 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 45 84 0 1 10 5 0 0 0 0 0 10 0 2500 0 0 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 2 0 0 0 0 0 2 3 0 0 0 0 90 0 0 0 0 0 0 0 0 0 0 0 0 100 0 0 0 0 44 0 0 0 0 12340
1318 2 1 -1 Night Reaver 19290 3 0 0 1 15332 3066 17 -1 -1 23 18 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 52 78 0 1 5 5 0 0 0 0 0 0 0 3300 0 0 13480 2 0 1 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 2 0 0 0 0 0 1 1 0 0 0 0 80 0 0 0 0 0 0 0 0 0 0 0 0 25 0 0 0 0 41 0 0 0 0 12340
1482 2 7 -1 Shadowfang 20089 3 0 0 1 14822 2964 13 -1 -1 24 19 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 29 55 0 4 8 5 0 0 0 0 0 0 0 2700 0 0 13440 2 0 1.6 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 2 0 0 0 0 0 1 3 0 0 0 0 75 0 0 0 0 0 0 0 0 0 0 0 0 25 0 0 0 0 41 0 0 0 0 12340
1959 2 1 -1 Cold Iron Pick 14038 2 0 0 1 6118 1223 17 -1 -1 17 12 0 0 0 0 0 0 0 0 1 0 2 7 2 6 4 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 27 41 0 1 5 4 0 0 0 0 0 0 0 3000 0 0 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 2 Also serves as a mining pick. 0 0 0 0 0 1 1 0 0 0 0 60 0 0 1024 165 0 0 0 0 0 0 0 0 1 0 0 0 0 22 0 0 0 0 12340
3194 2 5 -1 Black Malice 19622 3 0 0 1 12480 2496 17 -1 -1 21 16 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 48 73 0 1 6 5 0 0 0 0 0 0 0 3300 0 0 18205 2 0 2 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 2 0 0 0 0 0 2 1 0 0 0 0 75 0 0 0 0 0 0 0 0 0 0 0 0 25 0 0 0 0 41 0 0 0 0 12340
4446 2 15 -1 Blackvenom Blade 20369 3 0 0 1 17973 3594 13 -1 -1 26 21 0 0 0 0 0 0 0 0 1 0 1 3 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 21 39 0 1 7 5 0 0 0 0 0 0 0 1800 0 0 13518 2 0 2 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 2 0 0 0 0 0 1 3 0 0 0 0 60 0 0 0 0 0 0 0 0 0 0 0 0 50 0 0 0 0 42 0 0 0 0 12340
7682 2 15 -1 Torturing Poker 6555 3 0 0 1 38392 7678 13 -1 -1 34 29 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 26 49 0 5 7 2 0 0 0 0 0 0 0 1700 0 0 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 1 0 0 0 0 0 1 3 0 0 0 0 65 0 0 0 0 0 0 0 0 0 0 0 0 75 0 0 0 0 43 0 0 0 0 12340
7730 2 5 -1 Cobalt Crusher 15466 3 0 0 1 50733 10146 17 -1 -1 34 29 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 74 111 0 5 5 4 0 0 0 0 0 0 0 3200 0 0 18204 2 0 1.875 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 2 0 0 0 0 0 2 1 0 0 0 0 100 0 0 0 0 0 0 0 0 0 0 0 0 75 0 0 0 0 43 0 0 0 0 12340
13952 2 0 -1 Iceblade Hacker 28782 3 0 0 1 264251 52850 13 -1 -1 62 57 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 57 106 0 1 5 4 0 0 0 0 0 0 0 2000 0 0 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 1 0 0 0 0 0 1 3 0 0 0 0 90 0 0 0 0 0 0 0 0 0 0 0 0 225 0 0 0 0 48 0 0 0 0 12340
16039 2 8 -1 Ta'Kierthan Songblade 26674 3 0 0 1 267991 53598 17 -1 -1 57 52 0 0 0 0 0 0 0 0 1 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 129 194 0 1 20 6 0 0 0 0 0 0 0 3300 0 0 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 0 0 0 0 -1 0 -1 2 0 0 0 0 0 1 1 0 0 0 0 100 0 0 0 0 0 0 0 0 0 0 0 0 200 0 0 0 0 48 0 0 0 0 12340
@ariel- I think the bug still.
I tried with all above listed weapons and don't make the secondary damage (I deleted client cache folder)
rev: f1f6976f91952806f8b2bcc23fbbef5a8075fe73
Jildor
on 15 Feb 2018
They do. It doesn't appear in combat log, even when the packet sends info about secondary damage. Also the damage is pretty insignificant, but it's there.
ariel-
on 15 Feb 2018
Ah, ok thx 馃憤
Then if it doesn't appear in combat log, can it be considered a cosmetic bug?
Jildor
on 15 Feb 2018
No because it's blizzlike cosmetic bug :P
ariel-
on 15 Feb 2018
Related issues
Keader
路
3Comments
DDuarte
路
3Comments
ZenoX92
路
3Comments
Rushor
路
3Comments
Jildor
路
3Comments
Most helpful comment
No because it's blizzlike cosmetic bug :P