Trinitycore: [3.3.5] Spell/Mage: Arcane Potency not work properly

Created on 13 Jan 2017  路  7Comments  路  Source: TrinityCore/TrinityCore

Description:
http://wow.gamepedia.com/Arcane_Potency
http://wowwiki.wikia.com/wiki/Arcane_Potency

Current behaviour:
Arcane Potency is broken because:
a) Is not consumed by instant cast spells like Fire Blast, Arcane Explosion, Cone of Cold, Frost Nova, Arcane Missiles
b) Polymorph consume Arcane Potency.
c) Arcane Missiles not consumes the Arcane Potency.

Expected behaviour:
Arcane Potency should not comply mencioned items a, b, c.

Steps to reproduce the problem:

  1. Obtein Arcane Potency buff.
  2. Reproduce mencioned items a, b, c.

Branch(es): 3.3.5

TC rev. hash/commit: a6acd88

TDB version: TDB_full_world_335.62_2016_10_17 + updates

Operating system: Windows

Branch-3.3.5a Comp-Database Sub-Spells
Source
picture Noryad

Most helpful comment

Forget previous comment, SpellClassMask is not applied to SPELL_AURA_MOD_SPELL_CRIT_CHANCE auras. Why blizz made this a +crit instead of a charged mod (like most other +crit procs) is beyond me.

This issue can be divided:

  • Arcane Missiles is a two part spell (first is an aura that triggers the second, doing the actual missile and damage) we should somehow only calc crit for the dummy spell and then make the missiles inherit the calculated critical. (would fix aura consumption and getting the spell to work proper with the +crit present for each missile)
  • Polymorph on the other hand, is a damage class magic spell, core automatically calcs crit chance for it (the issue being: we shouldn't calc critical chance for spells that are unaffected)
picture ariel- on 30 Jan 2017
🎉3

All 7 comments

There also problem with proc from clearcasting.

I partially fixed that issue:

UPDATE spell_proc SET SpellFamilyMask2 = 0x0, SpellPhaseMask=0x2 WHERE SpellId = -31571;
UPDATE spell_proc SET SpellFamilyMask0 = 0x0, SpellFamilyMask1 = 0x0, SpellFamilyMask2 = 0x0 WHERE SpellId IN (57529, 57531);

but still problem with consumption from Arcane Missiles and Polymorph.
And I found it
https://github.com/FeenixServerProject/Archangel_2.4.3_Bugtracker/issues/201

Eliminationzx picture Eliminationzx on 13 Jan 2017

@Keader maybe it should be labeled with Comp-Core, 81f16b2 is the last commit from @ariel- about this issue :)

Noryad picture Noryad on 13 Jan 2017

http://wow.gamepedia.com/Arcane_Potency

This spell applies a buff on you that is consumed by the next crittable spell that you cast, not by the spell affected by PoM or Clearcasting, though they are often the same.

Noryad picture Noryad on 13 Jan 2017

a) Is not consumed by instant cast spells like Fire Blast, Arcane Explosion, Cone of Cold, Frost Nova, Arcane Missiles
c) Arcane Missiles not consumes the Arcane Potency.

c is included in a

All those spells do not consume Arcane Potency because they do not benefit from its critical increase!
According to SpellWork, Arcane Potency has a special SpellClassMask that only affects:

Warning, long list

Effect 0: Id 6 (SPELL_EFFECT_APPLY_AURA)
BasePoints = 30
Targets (1, 0) (TARGET_UNIT_CASTER, NO_TARGET)
Aura Id 57 (SPELL_AURA_MOD_SPELL_CRIT_CHANCE), value = 30, misc = 0 (0), miscB = 0, periodic = 0
SpellClassMask = 61400035 00001000 00000000
    - 11 - Frostbolt of Ages
    + 116 - Frostbolt (Rank 1)
    + 118 - Polymorph (Rank 1)
    + 133 - Fireball (Rank 1)
    + 143 - Fireball (Rank 2)
    + 145 - Fireball (Rank 3)
    + 205 - Frostbolt (Rank 2)
    + 587 - Conjure Food (Rank 1)
    + 597 - Conjure Food (Rank 2)
    + 759 - Conjure Mana Gem (Rank 1)
    + 837 - Frostbolt (Rank 3)
    + 990 - Conjure Food (Rank 3)
    + 2120 - Flamestrike (Rank 1)
    + 2121 - Flamestrike (Rank 2)
    + 2948 - Scorch (Rank 1)
    + 3140 - Fireball (Rank 4)
    + 3552 - Conjure Mana Gem (Rank 2)
    + 5504 - Conjure Water (Rank 1)
    + 5505 - Conjure Water (Rank 2)
    + 5506 - Conjure Water (Rank 3)
    + 6127 - Conjure Water (Rank 4)
    + 6129 - Conjure Food (Rank 4)
    + 7322 - Frostbolt (Rank 4)
    + 8400 - Fireball (Rank 5)
    + 8401 - Fireball (Rank 6)
    + 8402 - Fireball (Rank 7)
    + 8406 - Frostbolt (Rank 5)
    + 8407 - Frostbolt (Rank 6)
    + 8408 - Frostbolt (Rank 7)
    + 8422 - Flamestrike (Rank 3)
    + 8423 - Flamestrike (Rank 4)
    + 8444 - Scorch (Rank 2)
    + 8445 - Scorch (Rank 3)
    + 8446 - Scorch (Rank 4)
    + 10053 - Conjure Mana Gem (Rank 3)
    + 10054 - Conjure Mana Gem (Rank 4)
    + 10138 - Conjure Water (Rank 5)
    + 10139 - Conjure Water (Rank 6)
    + 10140 - Conjure Water (Rank 7)
    + 10144 - Conjure Food (Rank 5)
    + 10145 - Conjure Food (Rank 6)
    + 10148 - Fireball (Rank 8)
    + 10149 - Fireball (Rank 9)
    + 10150 - Fireball (Rank 10)
    + 10151 - Fireball (Rank 11)
    + 10179 - Frostbolt (Rank 8)
    + 10180 - Frostbolt (Rank 9)
    + 10181 - Frostbolt (Rank 10)
    + 10205 - Scorch (Rank 5)
    + 10206 - Scorch (Rank 6)
    + 10207 - Scorch (Rank 7)
    + 10215 - Flamestrike (Rank 5)
    + 10216 - Flamestrike (Rank 6)
    + 11366 - Pyroblast (Rank 1)
    - 12354 - Flame of Hakkar
    + 12505 - Pyroblast (Rank 2)
    + 12522 - Pyroblast (Rank 3)
    + 12523 - Pyroblast (Rank 4)
    + 12524 - Pyroblast (Rank 5)
    + 12525 - Pyroblast (Rank 6)
    + 12526 - Pyroblast (Rank 7)
    + 12824 - Polymorph (Rank 2)
    + 12825 - Polymorph (Rank 3)
    + 12826 - Polymorph (Rank 4)
    - 13878 - Scorch
    - 15241 - Scorch
    - 17195 - Scorch
    + 18809 - Pyroblast (Rank 8)
    - 18948 - Dark Energy
    - 18949 - Atal'ai Poison
    - 21229 - Frostbolt, Improved
    - 21230 - Fireball, Improved DoT
    + 25304 - Frostbolt (Rank 11)
    + 25306 - Fireball (Rank 12)
    + 27070 - Fireball (Rank 13)
    + 27071 - Frostbolt (Rank 12)
    + 27072 - Frostbolt (Rank 13)
    + 27073 - Scorch (Rank 8)
    + 27074 - Scorch (Rank 9)
    + 27086 - Flamestrike (Rank 7)
    + 27090 - Conjure Water (Rank 9)
    + 27101 - Conjure Mana Gem (Rank 5)
    + 27132 - Pyroblast (Rank 9)
    + 28271 - Polymorph (Turtle)
    + 28272 - Polymorph (Pig)
    + 28612 - Conjure Food (Rank 7)
    - 29515 - TEST Scorch
    - 29975 - Conjure Water (Rank 8)
    + 30451 - Arcane Blast (Rank 1)
    - 32826 - Polymorph Cast Visual (Rank 1)
    - 32990 - Enchanting Cast Visual (Rank 1)
    - 32991 - Nature Cast Visual (Rank 1)
    - 32992 - Ice Cast Visual (Rank 1)
    - 32993 - Fire Cast Visual (Rank 1)
    + 33717 - Conjure Food (Rank 8)
    + 33938 - Pyroblast (Rank 10)
    - 35377 - Scorch
    - 35927 - Arcane Blast
    - 36412 - Summon Nether Spikes
    - 36807 - Scorch
    - 36879 - Conjure Water
    - 36883 - Conjure Mana Diamond
    + 37420 - Conjure Water (Rank 8)
    - 37921 - Test Spiral (Rank 1)
    - 38274 - TEST Item Main Hand (Rank 1)
    - 38275 - TEST Ammo Basic (Rank 1)
    - 38276 - TEST Ammo Preferred (Rank 1)
    - 38391 - Scorch
    - 38556 - Throw
    - 38557 - Throw
    - 38558 - Throw
    - 38559 - Throw
    - 38560 - Throw
    - 38561 - Throw
    - 38562 - Throw
    - 38563 - Throw
    - 38564 - Throw
    - 38565 - Throw
    - 38566 - Throw
    - 38567 - Throw
    - 38568 - Throw
    - 38569 - Throw
    - 38570 - Throw
    - 38636 - Scorch
    + 38692 - Fireball (Rank 14)
    + 38697 - Frostbolt (Rank 14)
    - 38881 - Arcane Blast
    - 40822 - ZoomTemp (Rank 1)
    - 41060 - Return
    - 41346 - Poisonous Throw
    - 42332 - Throw Axe
    - 42357 - Axe Volley
    - 42359 - Axe Volley
    - 42412 - Throw Chum
    + 42832 - Fireball (Rank 15)
    + 42833 - Fireball (Rank 16)
    - 42834 - Fireball (Rank 17)
    + 42841 - Frostbolt (Rank 15)
    + 42842 - Frostbolt (Rank 16)
    + 42858 - Scorch (Rank 10)
    + 42859 - Scorch (Rank 11)
    + 42890 - Pyroblast (Rank 11)
    + 42891 - Pyroblast (Rank 12)
    + 42894 - Arcane Blast (Rank 2)
    + 42896 - Arcane Blast (Rank 3)
    + 42897 - Arcane Blast (Rank 4)
    + 42925 - Flamestrike (Rank 8)
    + 42926 - Flamestrike (Rank 9)
    + 42955 - Conjure Refreshment (Rank 1)
    + 42956 - Conjure Refreshment (Rank 2)
    + 42985 - Conjure Mana Gem (Rank 6)
    - 42986 - Conjure Mana Gem (Rank 7)
    - 43409 - Throw
    - 43515 - Cosmetic - Ashli's Fireball
    - 43520 - Cosmetic - Ashli's Fireball 01
    - 43521 - Create Darkrune
    - 43525 - Cosmetic - Ashli's Fireball 02
    - 43665 - Throw
    - 43993 - Harpoon (Rank 1)
    + 44614 - Frostfire Bolt (Rank 1)
    - 45108 - CK's Fireball (Rank 17)
    - 45461 - Fire Channel Visual (Rank 1)
    - 46224 - TempSmite (Rank 1)
    - 46440 - Cosmetic - Ashli's Fireball TEST
    - 46580 - TEST - Frostfire 2 (Rank 1)
    - 46602 - VehicleScriptTest (Rank 1)
    - 46704 - Raelorasz Fireball
    + 47610 - Frostfire Bolt (Rank 2)
    - 47723 - Scorch
    - 48975 - Throw
    - 49512 - Fireball
    - 50183 - Scorch
    - 51177 - Create Corrupted Fel-Ice Subzero Netherfrost Mana Shard (Rank 7)
    - 51235 - Dan's Test Fireball (Rank 1)
    - 51236 - Dan's Test Iceblast (Rank 1)
    - 52356 - Throw
    - 53325 - SelfSheep (Rank 4)
    - 54540 - Test Frostbolt Weapon (Rank 2)
    - 56938 - Scorch
    - 56969 - Arcane Blast
    - 59138 - Throw Weapon
    - 59603 - Throw
    - 59634 - Polymorph - Penguin
    + 61025 - Polymorph (Serpent)
    - 61168 - Throw
    + 61305 - Polymorph (Black Cat)
    + 61721 - Polymorph (Rabbit)
    + 61780 - Polymorph (Turkey)
    + 61780 - Polymorph (Turkey)
    - 65633 - Arcane Cast Visual (Rank 1)
    - 65791 - Arcane Blast
    - 67997 - Arcane Blast
    - 67998 - Arcane Blast
    - 67999 - Arcane Blast
    - 68812 - Throw
    - 71319 - Polymorph (Turkey)
    - 75412 - Scorch
    - 75419 - Scorch

ariel- picture ariel- on 28 Jan 2017

Forget previous comment, SpellClassMask is not applied to SPELL_AURA_MOD_SPELL_CRIT_CHANCE auras. Why blizz made this a +crit instead of a charged mod (like most other +crit procs) is beyond me.

This issue can be divided:

  • Arcane Missiles is a two part spell (first is an aura that triggers the second, doing the actual missile and damage) we should somehow only calc crit for the dummy spell and then make the missiles inherit the calculated critical. (would fix aura consumption and getting the spell to work proper with the +crit present for each missile)
  • Polymorph on the other hand, is a damage class magic spell, core automatically calcs crit chance for it (the issue being: we shouldn't calc critical chance for spells that are unaffected)
ariel- picture ariel- on 30 Jan 2017
🎉3

any news?

Eliminationzx picture Eliminationzx on 10 Feb 2017

No, spell never worked properly afaik, I need to fix a few other things before resuming work here.

ariel- picture ariel- on 10 Feb 2017
Was this page helpful?
0 / 5 - 0 ratings

Related issues

jerbookins picture jerbookins  路  3Comments
Rushor picture Rushor  路  3Comments
funjoker picture funjoker  路  3Comments
Keader picture Keader  路  3Comments
ZenoX92 picture ZenoX92  路  3Comments