Trinitycore: [3.3.5][Quest] Captain Garran Vimes - Missing endevent

[Rushor]

Description:
http://www.wowhead.com/npc=4944/captain-garran-vimes does not have a quest reward script.

Current behaviour: (Tell us what happens.)
http://www.wowhead.com/npc=4944/captain-garran-vimes does not have a quest reward script.

Expected behaviour: (Tell us what should happen instead.)
When http://www.wowhead.com/quest=1220/captain-vimes is rewarded, a tiny end event should happen.

Steps to reproduce the problem:

1. .quest add 1220
2. .go c id 4944
3. reward the quest > no event happens

Branch(es): 3.3.5 / master (Tell us which branch(es) this issue affects.)
3.3.5

TC rev. hash/commit: https://github.com/TrinityCore/TrinityCore/commit/3d5c1b83b15cfc9f73888eb525c64323266c1fd4

TDB version: TDB_full_world_335.62_2016_10_17 + updates

Operating system: Win10

[offl]

(@ENTRY,9,2,0,0,0,100,0,4000,4000,0,0,1,2,0,0,0,0,0,21,100,0,0,0,0,0,0,"Captain Garran Vimes - On Script - Say Line 2");

Maybe SMART_ACTION_STORE_TARGET_LIST + SMART_TARGET_STORED will be better?

[offl]

This can be fixed, as a core problem. But if he will say the text to player who didn't turn the quest, this will be only bad coding problem.
Also currently many scripts uses SMART_ACTION_STORE_TARGET_LIST + SMART_TARGET_STORED.
So I believe that this is a standard for cases like your.

[ghost]

May I suggest a layout/structure improvement for the SQL, is this version OK too?

-- [Q] Captain Vimes (http://www.wowhead.com/quest=1220/captain-vimes)
-- Captain Garran Vimes SAI
SET @ENTRY := 4944;
SET @SCRIPT := 494400;

UPDATE `creature_template` SET `AIName`= "SmartAI" WHERE `entry`= @ENTRY;

DELETE FROM `smart_scripts` WHERE `entryorguid`= @ENTRY AND `source_type`= 0;
DELETE FROM `smart_scripts` WHERE `entryorguid`= @SCRIPT AND `source_type`= 9;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES
(@ENTRY,0,0,0,20,0,100,0,1220,0,0,0,80,@SCRIPT,2,0,0,0,0,1,0,0,0,0,0,0,0,"Captain Garran Vimes - On quest 'Captain Vimes' completed - Run Script"),
(@SCRIPT,9,0,0,0,0,100,0,2000,2000,0,0,1,0,0,0,0,0,0, 1,  0,0,0,0,0,0,0,"Captain Garran Vimes - On Script - Say Line 0"),
(@SCRIPT,9,1,0,0,0,100,0,4000,4000,0,0,1,1,0,0,0,0,0, 1,  0,0,0,0,0,0,0,"Captain Garran Vimes - On Script - Say Line 1"),
(@SCRIPT,9,2,0,0,0,100,0,4000,4000,0,0,1,2,0,0,0,0,0,21,100,0,0,0,0,0,0,"Captain Garran Vimes - On Script - Say Line 2");

DELETE FROM `creature_text` WHERE `entry`= @ENTRY;
INSERT INTO `creature_text` (`entry`,`groupid`,`id`,`text`,`type`,`language`,`probability`,`emote`,`duration`,`sound`,`BroadcastTextId`,`comment`) VALUES 
(@ENTRY, 0, 0, "%s places the scroll on the table, and reads...", 16, 0, 100, 0, 0, 0, 1671, 'Captain Garran Vimes'),
(@ENTRY, 1, 0, "By the Light!  This cursed spy was a good one! I'm glad he's dead.", 12, 0, 100, 0, 0, 0, 1672, 'Captain Garran Vimes'),
(@ENTRY, 2, 0, "Thank you for this report, $n.  It is now clear that we must tighten our patrols near Theramore.", 12, 0, 100, 0, 0, 0, 1673, 'Captain Garran Vimes');

BTW, in the wowhead comment http://www.wowhead.com/quest=1220/deprecated-captain-vimes#comments:id=231855 the player said that your character will salute. Is that too complicated to achieve without a core script?

[Rushor]

maybe a spell triggers this salute effect? is there already something similar in tc?

[Rushor]

edit 2: updated the texttargeting like mentioned from offl

[offl]

Huh, this event is more interesting on retail(orientation switches) :)
And yes, seems like "salute effect" is triggered by a spell.
Here's the spell. This spell currently also used in Force Commander Danath Trollbane SAI. Video.

[ghost]

Well, the orientation change looks like it could just as well be caused by the player (random click). The spell, though, has got a powerful visual, compared to the fact that the player only performs a salute.

• http://www.wowhead.com/spell=6245/force-target-salute

---

[edit] - I presume the spell can just as easily be cast via SAI action 11 and Vimes can salute via SMART_ACTION_PLAY_EMOTE (5) (unless the spell forces both caster and target to salute).

[offl]

Well, the orientation change looks like it could just as well be caused by the player (random click).

No, he changes the orientation immediately after turning the quest. He faces at the object that he summoned.

[ghost]

Of course. You meant Captain Garran Vimes. I thought you were referring to the player. My bad.

---

[edit] As a matter of fact, Vimes changes orientation 3 times when he:

1. faces the scroll (object) on the table,
2. faces the player to salute,
3. goes back to his original default orientation after the event is over.

[offl]

Now, with all of these details above, this can be hard to implement.
Sorry for that, Rushor :D
(Of course this can be pushed without these details).

[Rushor]

could someone research if we have a sniff for this? else i would spawn the object and change the orientation without sniffdatas

[offl]

Can be sniffed and today.

[Rushor]

another endevent that is missing - https://youtu.be/KTHYaf9o9kw?t=187

http://wotlk.openwow.com/quest=1284 going to update both of them

[Rushor]

alright here we go:

-- [Q] Captain Vimes -- http://www.wowhead.com/quest=1220
-- [Q] Suspicious Hoofprints -- http://wotlk.openwow.com/quest=1284
-- Captain Garran Vimes SAI
SET @ENTRY := 4944;
UPDATE `creature_template` SET `AIName`="SmartAI" WHERE `entry`=@ENTRY;
DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES
(@ENTRY,0,0,1,20,0,100,0,1220,0,0,0,64,1,0,0,0,0,0,7,0,0,0,0,0,0,0,"Captain Garran Vimes - On Quest 'Captain Vimes' Finished - Store Targetlist"),
(@ENTRY,0,1,0,61,0,100,0,1220,0,0,0,80,@ENTRY*100+00,2,0,0,0,0,1,0,0,0,0,0,0,0,"Captain Garran Vimes - On Quest 'Captain Vimes' Finished - Run Script"),
(@ENTRY,0,2,3,20,0,100,0,1284,0,0,0,64,2,0,0,0,0,0,7,0,0,0,0,0,0,0,"Captain Garran Vimes - On Quest 'Suspicious Hoofprints' Finished - Store Targetlist"),
(@ENTRY,0,3,0,61,0,100,0,1284,0,0,0,80,@ENTRY*100+01,2,0,0,0,0,1,0,0,0,0,0,0,0,"Captain Garran Vimes - On Quest 'Suspicious Hoofprints' Finished - Run Script");

-- Actionlist SAI
SET @ENTRY := 494400;
DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=9;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES
(@ENTRY,9,0,0,0,0,100,0,1000,1000,0,0,1,0,0,0,0,0,0,1,0,0,0,0,0,0,0,"Captain Garran Vimes - On Script - Say Line 0"),
(@ENTRY,9,1,0,0,0,100,0,0,0,0,0,50,21128,10,0,0,0,0,8,0,0,0,-3735.3483,-4554.6777,28.5526,3.55917,"Captain Garran Vimes - On Script - Summon Gameobject 'Orc Spy Report'"),
(@ENTRY,9,2,0,0,0,100,0,2000,2000,0,0,1,1,0,0,0,0,0,1,0,0,0,0,0,0,0,"Captain Garran Vimes - On Script - Say Line 1"),
(@ENTRY,9,3,0,0,0,100,0,2000,2000,0,0,66,0,0,0,0,0,0,8,0,0,0,0,0,0,1.93417,"Captain Garran Vimes - On Script - Set Orientation 1,93417"),
(@ENTRY,9,4,0,0,0,100,0,3000,3000,0,0,66,0,0,0,0,0,0,12,1,0,0,0,0,0,0,"Captain Garran Vimes - On Script - Set Orientation Player"),
(@ENTRY,9,5,0,0,0,100,0,0,0,0,0,1,2,0,0,0,0,0,12,1,0,0,0,0,0,0,"Captain Garran Vimes - On Script - Say Line 2"),
(@ENTRY,9,6,0,0,0,100,0,2000,2000,0,0,85,6245,2,0,0,0,0,12,1,0,0,0,0,0,0,"Captain Garran Vimes - On Script - Invoker Cast 'Force Target - Salute'"),
(@ENTRY,9,7,0,0,0,100,0,1000,1000,0,0,11,6245,2,0,0,0,0,1,0,0,0,0,0,0,0,"Captain Garran Vimes - On Script - Cast 'Force Target - Salute'"),
(@ENTRY,9,8,0,0,0,100,0,3000,3000,0,0,66,0,0,0,0,0,0,8,0,0,0,0,0,0,1.151920,"Captain Garran Vimes - On Script - Set Orientation 1,151920");

-- Actionlist SAI
SET @ENTRY := 494401;
DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=9;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES
(@ENTRY,9,0,0,0,0,100,0,10,10,0,0,1,3,0,0,0,0,0,12,1,0,0,0,0,0,0,"On Script - Say Line 3"),
(@ENTRY,9,1,0,0,0,100,0,0,0,0,0,12,5088,5,0,0,0,0,8,0,0,0,-3717.0373,-4523.4580,25.83386,5.15678,"On Script - Summon Creature 'Falgran Hastil'"),
(@ENTRY,9,2,0,0,0,100,0,5000,5000,0,0,1,0,0,0,0,0,0,19,4948,50,0,0,0,0,0,"On Script - Say Line 0");

-- Falgran Hastil SAI
SET @ENTRY := 5088;
UPDATE `creature_template` SET `AIName`="SmartAI" WHERE `entry`=@ENTRY;
DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=0;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES
(@ENTRY,0,0,0,63,0,100,0,0,0,0,0,53,0,@ENTRY*100+00,0,0,0,0,1,0,0,0,0,0,0,0,"Falgran Hastil - On Just Created - Start Waypoint"),
(@ENTRY,0,1,0,40,0,100,0,4,@ENTRY*100+00,0,0,80,@ENTRY*100+00,2,0,0,0,0,1,0,0,0,0,0,0,0,"Falgran Hastil - On Waypoint 4 Reached - Run Script"),
(@ENTRY,0,2,0,40,0,100,0,4,@ENTRY*100+01,0,0,41,1000,0,0,0,0,0,1,0,0,0,0,0,0,0,"Falgran Hastil - On Waypoint 4 Reached - Despawn In 1000 ms");

-- Actionlist SAI
SET @ENTRY := 508800;
DELETE FROM `smart_scripts` WHERE `entryorguid`=@ENTRY AND `source_type`=9;
INSERT INTO `smart_scripts` (`entryorguid`,`source_type`,`id`,`link`,`event_type`,`event_phase_mask`,`event_chance`,`event_flags`,`event_param1`,`event_param2`,`event_param3`,`event_param4`,`action_type`,`action_param1`,`action_param2`,`action_param3`,`action_param4`,`action_param5`,`action_param6`,`target_type`,`target_param1`,`target_param2`,`target_param3`,`target_x`,`target_y`,`target_z`,`target_o`,`comment`) VALUES
(@ENTRY,9,0,0,0,0,100,0,1000,1000,0,0,66,0,0,0,0,0,0,19,4944,50,0,0,0,0,0,"On Script - Set Orientation Closest Creature 'Captain Garran Vimes'"),
(@ENTRY,9,1,0,0,0,100,0,3000,3000,0,0,17,16,0,0,0,0,0,1,0,0,0,0,0,0,0,"On Script - Play Kneel"),
(@ENTRY,9,2,0,0,0,100,0,2000,2000,0,0,17,26,0,0,0,0,0,1,0,0,0,0,0,0,0,"On Script - Play Stand"),
(@ENTRY,9,3,0,0,0,100,0,1000,1000,0,0,1,0,0,0,0,0,0,1,0,0,0,0,0,0,0,"On Script - Say Line 0"),
(@ENTRY,9,4,0,0,0,100,0,4000,4000,0,0,11,6245,0,0,0,0,0,1,0,0,0,0,0,0,0,"On Script - Cast 'Force Target - Salute'"),
(@ENTRY,9,5,0,0,0,100,0,2000,2000,0,0,53,1,508801,0,0,0,0,1,0,0,0,0,0,0,0,"On Script - Start Waypoint");

DELETE FROM `waypoints` WHERE `entry`=508800;
INSERT INTO `waypoints` (`entry`, `pointid`, `position_x`, `position_y`, `position_z`, `point_comment`) VALUES 
(508800, 1, -3714.99, -4527.66, 25.8339, 'Falgran Hastil - Path 1'),
(508800, 2, -3712.47, -4533.24, 25.8339, 'Falgran Hastil - Path 1'),
(508800, 3, -3716.93, -4541.17, 25.8339, 'Falgran Hastil - Path 1'),
(508800, 4, -3724.09, -4545.34, 25.8339, 'Falgran Hastil - Path 1');
-- 
DELETE FROM `waypoints` WHERE `entry`=508801;
INSERT INTO `waypoints` (`entry`, `pointid`, `position_x`, `position_y`, `position_z`, `point_comment`) VALUES 
(508801, 1, -3716.93, -4541.17, 25.8339, 'Falgran Hastil - Path 2'),
(508801, 2, -3712.47, -4533.24, 25.8339, 'Falgran Hastil - Path 2'),
(508801, 3, -3714.99, -4527.66, 25.8339, 'Falgran Hastil - Path 2'),
(508801, 4, -3718.48, -4522.41, 25.8338, 'Falgran Hastil - Path 2');

DELETE FROM `creature_text` WHERE `entry` IN (4944, 4948, 5088);
INSERT INTO `creature_text` (`entry`, `groupid`, `id`, `text`, `type`, `language`, `probability`, `emote`, `duration`, `sound`, `BroadcastTextId`, `comment`) VALUES 
(4944, 0, 0, '%s places the scroll on the table, and reads...', 16, 0, 100, 0, 0, 0, 1671, 'Captain Garran Vimes'),
(4944, 1, 0, 'By the Light!  This cursed spy was a good one! I''m glad he''s dead.', 12, 0, 100, 5, 0, 0, 1672, 'Captain Garran Vimes'),
(4944, 2, 0, 'Thank you for this report, $n.  It is now clear that we must tighten our patrols near Theramore.', 12, 0, 100, 0, 0, 0, 1673, 'Captain Garran Vimes'),
(4944, 3, 0, 'Tesoran! I need someone--Falgran Hastil, preferably--to take care of $n''s lead on the prints near the Shady Rest Inn.', 12, 0, 100, 1, 0, 0, 1753, 'Captain Garran Vimes'),
(4948, 0, 0, 'Right away, sir.', 12, 0, 100, 1, 0, 0, 1754, 'Adjutant Tesoran'),
(5088, 0, 0, 'Falgran Hastil reporting, sir. I will find where the hoofprints lead and report back to you.', 12, 0, 100, 1, 0, 0, 1752, 'Falgran Hastil');

[Kittnz]

I would have said go push it Rushor but you can't push anymore :(

[Rushor]

thanks for adding it to the repo @Kittnz :)

btw @offl could you recheck if there are some more missing end events for http://wotlk.openwow.com/npc=4944#starts or http://wotlk.openwow.com/npc=4944#ends. While we are at this npc we could fix everything for him, if anything is missing :)

[offl]

No, nothing.