Trinitycore: [3.3.5] Spell/Druid: Cyclone not work properly with Divine Shield / Ice block

[Noryad]

Description:
Divine Shield: Protects the paladin from all damage and spells for 12 sec ...
The problem: Cyclone of druid affects a paladin with divine shield.

Current behaviour:
Cyclone of druid affects a paladin with divine shield.

Expected behaviour:
The paladin with Divine Shield must be immune to the Cyclone.

Steps to reproduce the problem:

1. Paladin casts Divine Shield.
2. Druid casts Cyclone to Paladin.
3. Paladin with Divine Shield is in Cyclone.

Note the same occur with Ice Block (mage).

Branch(es): 3.3.5

TC rev. hash/commit: b049caf

TDB version: TDB_full_world_335.62_2016_10_17 + updates

Operating system: Windows

[ariel-]

Cyclone has SPELL_ATTR1_UNAFFECTED_BY_SCHOOL_IMMUNE and Divine Shield is School immunity... expected result?

[Noryad]

http://wow.gamepedia.com/Divine_Shield
http://wowwiki.wikia.com/wiki/Divine_Shield
Divine Shield protects the paladin from all unfriendly spells then cyclone should be inmune.
The only abilities in the game that can dispel Divine Shield are the Priest's Mass Dispel and the Warrior's Shattering Throw. Is important to validate that Divine Shield cannot be cast under the effect of Cyclone and similar effects.

[ariel-]

Note, there are spells that divine shield cannot protect against (for example http://www.wowhead.com/spell=70063)

In that link:

Divine Shield cannot be cast under the effect of [Cyclone] and similar effects.

[Xiledria]

Fury of Frostmourne has different spell attribute - SPELL_ATTR0_UNAFFECTED_BY_INVULNERABILITY

and now it is possible to dispel it even without mass dispel with Dispel Magic (which does not even have spell attrr to be unaffected by invulnerability / immunity)

I guess it should have something to do with effect value 0 / 1, because divine shield has 2 SPELL_AURA_SCHOOL_IMMUNITY, I guess one of them is immunity and the second one is invulnerability which prevents even spells with SPELL_ATTR1_UNAFFECTED_BY_SCHOOL_IMMUNE or something like that :D

[Noryad]

The same problem occur with Ice Block (mage), then:
1- Cyclone should not affects targets under effect of Divine Shield / Ice Block. Expected result: Immune.
2- Divine Shield / Ice Block can not be casted under effect of Cyclone. Actually when Divine Shield / Ice Block is casted nothing occour but the ability is put into cooldown and should not.
Note warrior in Bladestorm is inmune to Cyclone.
From patch 6.0.2 cyclone can be canceled by immunity effects (i.e. Divine Shield, Ice Block, etc.), but we are in 3.3.5a. (http://wow.gamepedia.com/Cyclone)

[Noryad]

Catapults in Strand of the Ancients can receive cyclone too and should not.

[Shauren]

Being able to cast cyclone on divine shield (which is what the bug is about) has nothing to do with being able to cast divine shield while cycloned. These two checks should not be using the same logic. Similarly to how DK Anti-Magic Shell prevents debuff applications but does not dispel them.

[Noryad]

Another important observation.
it is very similar in mechanics to [Banish]: targets affected by Cyclone cannot move or perform any actions, are immune to receiving heals or buffs, and also completely immune to all incoming damage and unable to be debuffed.

[Shauren]

No, don't compare it to Banish, that one has a special case - if you recast Banish on the same target, it unbanishes it

[ariel-]

No, don't compare it to Banish, that one has a special case - if you recast Banish on the same target, it unbanishes it

And, incidentally, this mechanic works correctly

[ariel-]

About the dispel magic dispelling Divine Shield... its again about possitivity spell check, previous system did check possitivity only in IsImmunedToSpell, Dispel Magic was immuned in IsImmunedToDamage (albeit wrongly, because dispel magic is no damage spell).

It will require to rewrite the whole possitive/negative stuff depending on both spell effect and target (because spells like this can be both)

[Noryad]

Dispel Magic is dispeling Ice block too.

[Noryad]

Cyclone tosses the enemy target into the air, preventing all action but making them invulnerable for up to 6 sec... In current revision when the target is under effects of cyclone and the druid casts cyclone again, the target is affected. Is this mechanism correct? Should be immune to the next cyclone?

[Jildor]

5130

I think should be immune to the next Cyclone

[Keader]

Cylone in clycloned targets should get immune result