Trinitycore: [3.3.5] Crash waypointmovementgenerator

[Mrgrasser]

Description: crash log RelWithDebInfo

unknown_worldserver.exe_[30-11_3-53-59].txt

Branch(es): 3.3.5 / master (Tell us which branch(es) this issue affects.)

TC rev. hash/commit: 0df7d22a89c09e3a15711211dec77fed8613cd1a

TDB version: 62

Operating system: Windows Server 2012 R2

[Riztazz]

Ill take a look at it when im back home, currently on tablet so cant read the log properly, its something related to transports i think? I should be home tomorrow and ill fix it;p

edit: not transports, viewing on tablet sucks :P

[Mrgrasser]

yes some time worldsever.exe crash some time 3h some time 1d stable server

[Kittnz]

Revision: TrinityCore rev. unknown 1970-01-01 00:00:00 +0000 (Archived branch) (Win64, RelWithDebInfo, Static)

[Mrgrasser]

@Kittnz RelWithDebInfo is approved ?
if is I have one crash log about spells creat new issue

[Riztazz]

This doesnt make sense, this creature that caused the crash doesnt even move on clean TC, do you run clean TC or have some custom changes to your core?

edit: nvm, found a way to reproduce it

[Mrgrasser]

yeh , I have custom code but not Change for procedures or commit TC

[Mrgrasser]

I have now 2 crash log with RelWithDebInfo this crash appeared after 28050f338dfc66e0c40b6a3915bf96e38e0613e5 , but next crash was always appeared

[Riztazz]

Ok, this is due to very very bad script, we cannot have faulty scripts anymore because we're not sending one point at the time anymore, this is sql to fix that crash, i'll think about a way to prevent crash and reset script in the future, similar crashes might happen due to bad scripts, in this case a creature launched WPs then stopped and then launched again, same with errors in console, so remember folks - we're no longer sending one point at the time, we're sending entire path till first delay, so we cant issue another movement generator while one is previously in use

DELETE FROM `smart_scripts` WHERE `entryorguid` IN (-202776, -202775, -202778, -202777);
INSERT INTO `smart_scripts` (`entryorguid`, `source_type`, `id`, `link`, `event_type`, `event_phase_mask`, `event_chance`, `event_flags`, `event_param1`, `event_param2`, `event_param3`, `event_param4`, `action_type`, `action_param1`, `action_param2`, `action_param3`, `action_param4`, `action_param5`, `action_param6`, `target_type`, `target_param1`, `target_param2`, `target_param3`, `target_x`, `target_y`, `target_z`, `target_o`, `comment`) VALUES
(-202776, 0, 0, 1, 38, 0, 100, 512, 50, 0, 0, 0, 53, 1, 3665600, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Silver Covenant Sentinel - On Data Set 50 0 - Start Waypoint'),
(-202776, 0, 1, 0, 61, 0, 100, 512, 0, 0, 0, 0, 22, 1, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Silver Covenant Sentinel - On Data Set 50 0 - Set Event Phase 1'),
(-202776, 0, 2, 3, 40, 1, 100, 512, 1, 0, 0, 0, 66, 0, 0, 0, 0, 0, 0, 19, 37846, 0, 0, 0, 0, 0, 0, 'Silver Covenant Sentinel - On Waypoint 1 Reached - Set Orientation Closest Creature \'Blood-Queen Lana\'thel\' (Phase 1)'),
(-202776, 0, 3, 4, 61, 1, 100, 512, 0, 0, 0, 0, 17, 425, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Silver Covenant Sentinel - On Waypoint 1 Reached - Set Emote State 425 (Phase 1)'),
(-202776, 0, 4, 5, 61, 1, 100, 512, 0, 0, 0, 0, 54, 1500000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Silver Covenant Sentinel - On Waypoint 1 Reached - pause waypoint (Phase 1)'),
(-202776, 0, 5, 12, 61, 1, 100, 512, 0, 0, 0, 0, 22, 2, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Silver Covenant Sentinel - On Waypoint 1 Reached - Set Event Phase 2 (Phase 1)'),
(-202776, 0, 6, 0, 38, 0, 100, 512, 51, 0, 0, 0, 75, 71365, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Silver Covenant Sentinel - On Data Set 51 0 - Add Aura \'Freeze Guards\' (Phase 1)'),
(-202776, 0, 7, 8, 38, 0, 100, 512, 52, 0, 0, 0, 28, 71365, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Silver Covenant Sentinel - On Data Set 52 0 - Remove Aura \'Freeze Guards\''),
(-202776, 0, 8, 0, 61, 0, 100, 512, 0, 0, 0, 0, 80, 3665600, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Silver Covenant Sentinel - On Data Set 52 0 - Run Script'),
(-202776, 0, 9, 0, 38, 0, 100, 512, 53, 0, 0, 0, 65, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Silver Covenant Sentinel - On Data Set 53 0 - resume Waypoint'),
(-202776, 0, 10, 11, 40, 0, 100, 512, 2, 0, 0, 0, 66, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Silver Covenant Sentinel - On Waypoint 2 Reached - Set Orientation Home Position'),
(-202776, 0, 11, 0, 61, 0, 100, 512, 0, 0, 0, 0, 17, 26, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Silver Covenant Sentinel - On Waypoint 2 Reached - Set Emote State 26'),
(-202776, 0, 12, 0, 61, 1, 100, 512, 0, 0, 0, 0, 1, 1, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Silver Covenant Sentinel - On Waypoint 2 Reached - Say Line 1'),

(-202775, 0, 0, 1, 38, 0, 100, 512, 50, 0, 0, 0, 53, 1, 3665601, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Silver Covenant Sentinel - On Data Set 50 0 - Start Waypoint'),
(-202775, 0, 1, 0, 61, 0, 100, 512, 0, 0, 0, 0, 22, 1, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Silver Covenant Sentinel - On Data Set 50 0 - Set Event Phase 1'),
(-202775, 0, 2, 3, 40, 1, 100, 512, 1, 0, 0, 0, 66, 0, 0, 0, 0, 0, 0, 19, 37846, 0, 0, 0, 0, 0, 0, 'Silver Covenant Sentinel - On Waypoint 1 Reached - Set Orientation Closest Creature \'Blood-Queen Lana\'thel\' (Phase 1)'),
(-202775, 0, 3, 4, 61, 1, 100, 512, 0, 0, 0, 0, 17, 425, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Silver Covenant Sentinel - On Waypoint 1 Reached - Set Emote State 425 (Phase 1)'),
(-202775, 0, 4, 5, 61, 1, 100, 512, 0, 0, 0, 0, 54, 1500000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Silver Covenant Sentinel - On Waypoint 1 Reached - pause Waypoint (Phase 1)'),
(-202775, 0, 5, 0, 61, 1, 100, 512, 0, 0, 0, 0, 22, 2, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Silver Covenant Sentinel - On Waypoint 1 Reached - Set Event Phase 2 (Phase 1)'),
(-202775, 0, 6, 0, 38, 0, 100, 512, 51, 0, 0, 0, 75, 71365, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Silver Covenant Sentinel - On Data Set 51 0 - Add Aura \'Freeze Guards\' (Phase 1)'),
(-202775, 0, 7, 8, 38, 0, 100, 512, 52, 0, 0, 0, 28, 71365, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Silver Covenant Sentinel - On Data Set 52 0 - Remove Aura \'Freeze Guards\''),
(-202775, 0, 8, 0, 61, 0, 100, 512, 0, 0, 0, 0, 80, 3665600, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Silver Covenant Sentinel - On Data Set 52 0 - Run Script'),
(-202775, 0, 9, 0, 38, 0, 100, 512, 53, 0, 0, 0, 65, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Silver Covenant Sentinel - On Data Set 53 0 - resume Waypoint'),
(-202775, 0, 10, 11, 40, 0, 100, 512, 2, 0, 0, 0, 66, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Silver Covenant Sentinel - On Waypoint 2 Reached - Set Orientation Home Position'),
(-202775, 0, 11, 0, 61, 0, 100, 512, 0, 0, 0, 0, 17, 26, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Silver Covenant Sentinel - On Waypoint 2 Reached - Set Emote State 26'),

(-202778, 0, 0, 1, 38, 0, 100, 512, 50, 0, 0, 0, 53, 1, 3665701, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Sunreaver War Mage - On Data Set 50 0 - Start Waypoint'),
(-202778, 0, 1, 0, 61, 0, 100, 512, 0, 0, 0, 0, 22, 1, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Sunreaver War Mage - On Data Set 50 0 - Set Event Phase 1'),
(-202778, 0, 2, 3, 40, 1, 100, 512, 1, 0, 0, 0, 66, 0, 0, 0, 0, 0, 0, 19, 37846, 0, 0, 0, 0, 0, 0, 'Sunreaver War Mage - On Waypoint 1 Reached - Set Orientation Closest Creature \'Blood-Queen Lana\'thel\' (Phase 1)'),
(-202778, 0, 3, 4, 61, 1, 100, 512, 0, 0, 0, 0, 17, 425, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Sunreaver War Mage - On Waypoint 1 Reached - Set Emote State 425 (Phase 1)'),
(-202778, 0, 4, 5, 61, 1, 100, 512, 0, 0, 0, 0, 54, 1500000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Sunreaver War Mage - On Waypoint 1 Reached - pause Waypoint (Phase 1)'),
(-202778, 0, 5, 0, 61, 1, 100, 512, 0, 0, 0, 0, 22, 2, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Sunreaver War Mage - On Waypoint 1 Reached - Set Event Phase 2 (Phase 1)'),
(-202778, 0, 6, 0, 38, 0, 100, 512, 51, 0, 0, 0, 75, 71365, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Sunreaver War Mage - On Data Set 51 0 - Add Aura \'Freeze Guards\' (Phase 1)'),
(-202778, 0, 7, 8, 38, 0, 100, 512, 52, 0, 0, 0, 28, 71365, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Sunreaver War Mage - On Data Set 52 0 - Remove Aura \'Freeze Guards\''),
(-202778, 0, 8, 0, 61, 0, 100, 512, 0, 0, 0, 0, 80, 3665600, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Sunreaver War Mage - On Data Set 52 0 - Run Script'),
(-202778, 0, 9, 0, 38, 0, 100, 512, 53, 0, 0, 0, 65, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Sunreaver War Mage - On Data Set 53 0 - resume Waypoint'),
(-202778, 0, 10, 11, 40, 0, 100, 512, 2, 0, 0, 0, 66, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Sunreaver War Mage - On Waypoint 2 Reached - Set Orientation Home Position'),
(-202778, 0, 11, 0, 61, 0, 100, 512, 0, 0, 0, 0, 17, 26, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Sunreaver War Mage - On Waypoint 2 Reached - Set Emote State 26'),

(-202777, 0, 0, 1, 38, 0, 100, 512, 50, 0, 0, 0, 53, 1, 3665700, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Sunreaver War Mage - On Data Set 50 0 - Start Waypoint'),
(-202777, 0, 1, 0, 61, 0, 100, 512, 0, 0, 0, 0, 22, 1, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Sunreaver War Mage - On Data Set 50 0 - Set Event Phase 1'),
(-202777, 0, 2, 3, 40, 1, 100, 512, 1, 0, 0, 0, 66, 0, 0, 0, 0, 0, 0, 19, 37846, 0, 0, 0, 0, 0, 0, 'Sunreaver War Mage - On Waypoint 1 Reached - Set Orientation Closest Creature \'Blood-Queen Lana\'thel\' (Phase 1)'),
(-202777, 0, 3, 4, 61, 1, 100, 512, 0, 0, 0, 0, 17, 425, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Sunreaver War Mage - On Waypoint 1 Reached - Set Emote State 425 (Phase 1)'),
(-202777, 0, 4, 5, 61, 1, 100, 512, 0, 0, 0, 0, 54, 1500000, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Sunreaver War Mage - On Waypoint 1 Reached - pause Waypoint (Phase 1)'),
(-202777, 0, 5, 0, 61, 1, 100, 512, 0, 0, 0, 0, 22, 2, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Sunreaver War Mage - On Waypoint 1 Reached - Set Event Phase 2 (Phase 1)'),
(-202777, 0, 6, 0, 38, 0, 100, 512, 51, 0, 0, 0, 75, 71365, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Sunreaver War Mage - On Data Set 51 0 - Add Aura \'Freeze Guards\' (Phase 1)'),
(-202777, 0, 7, 8, 38, 0, 100, 512, 52, 0, 0, 0, 28, 71365, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Sunreaver War Mage - On Data Set 52 0 - Remove Aura \'Freeze Guards\''),
(-202777, 0, 8, 0, 61, 0, 100, 512, 0, 0, 0, 0, 80, 3665600, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Sunreaver War Mage - On Data Set 52 0 - Run Script'),
(-202777, 0, 9, 0, 38, 0, 100, 512, 53, 0, 0, 0, 65, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Sunreaver War Mage - On Data Set 53 0 - resume Waypoint'),
(-202777, 0, 10, 11, 40, 0, 100, 512, 2, 0, 0, 0, 66, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Sunreaver War Mage - On Waypoint 2 Reached - Set Orientation Home Position'),
(-202777, 0, 11, 0, 61, 0, 100, 512, 0, 0, 0, 0, 17, 26, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 'Sunreaver War Mage - On Waypoint 2 Reached - Set Emote State 26');

This script is crap and should be rewritten, this only patches the crash

[Mrgrasser]

So back your commit for rewritten script , ty @Riztazz

[jackpoz]

float m_positionX = 8119.063965
float m_positionY = 784.381653
float m_positionZ = 481.559753
float m_orientation = 1.114498
unsigned int m_mapId = 0x23B
std::string m_name = "Silver Covenant Sentinel"
unsigned int m_spawnId = 0x31818

gotta love WheatyExceptionReport crashlogs, so many useful infos :)

[Aokromes]

This bug is still valid? riztazz's commit was removed.

[Aokromes]

No answer after months, closing. If this bug is still valid open a new ticket with updated core.

[jackpoz]

see https://github.com/TrinityCore/TrinityCore/issues/18471#issuecomment-386813404

[jackpoz]

https://github.com/TrinityCore/TrinityCore/commit/76667e45a902f86bd341d40efa28037137e5e541 fixed it (tested ingame)