Trinitycore: Gameobject (Castbarcaption)

[dr-j]

Description:
In gameobject template there is field called castbarcaption which contains text which is displayed in cast bar while gameobect is been used or opened, however it appears that this should come from Broadcast text.

Current behaviour: Tell us what happens
The current behaviour is that text is taken directly from field in gameobject template
Expected behaviour: Tell us what should happen instead
The Castbarcaption text should be taken from broadcast text

This is verified with a number of gameobject types

type 0 Door Data 4 (openTextID (Unknown Text ID)) is broadcast text id, if you check the broadcast text id which is held in data4 for such example you will find it matches the text held in Castbarcaption

Type 1 Button Data 6 (openTextID (Unknown Text ID)) is broadcast text id, if you check the broadcast text id which is held in data6 for such example you will find it matches the text held in Castbarcaption

Type 2 Questgiver Data 6 (openTextID (Unknown Text ID)) is broadcast text id, if you check the broadcast text id which is held in data6 for such example you will find it matches the text held in Castbarcaption

Type 3 Chest Data 14 (openTextID (Unknown Text ID)) is broadcast text id, if you check the broadcast text id which is held in data14 for such example you will find it matches the text held in Castbarcaption

Type 6 Trap Data 12 (openTextID (Unknown Text ID)) is broadcast text id, if you check the broadcast text id which is held in data12 for such example you will find it matches the text held in Castbarcaption

Type 10 Goober Data 14 (openTextID (Unknown Text ID)) is broadcast text id, if you check the broadcast text id which is held in data14 for such example you will find it matches the text held in Castbarcaption.

[TrinityCoreBot]

This issue is not considered valid because of the following reasons:

• No proper commit hash (revision)

Please read http://bit.ly/tc-issuetracker-and-you . Thanks.

[soulfrost]

u think that easyer make whole system for this instad of making locales for ~10 cast bar options? srly?

[DDuarte]

Except that we already have broadcast_text and locales_broadcast_text...

[Shauren]

Negative. This field is part of template sent in SMSG_QUERY_GAME_OBJECT_RESPONSE (not in dataX fields) on both 3.3.5 and 6.x branches. Not to mention that back in 2010 broadcast_text didn't exist...

[dr-j]

Ye this was bought up as find it strange that there would be both castbarcaption and reference to broadcast text for everysingle castbar caption, and how do we know for sure that there was no broadcast text in 2010 as seems far from coicidental that the values in these fields match the exact same text in broadcast text.

And I checked a load of these and every single one the value from the specified data field (depending on type) when used as ID to query broadcast text gives exact same text as specified in castbarcaption.

[Shauren]

Strange or not - castbarcaption exists as separate string field in SMSG_QUERY_GAME_OBJECT_RESPONSE, gameobject_template table is built from that packet so we are sending the same data there as blizz sent to us, that is why nothing needs to be changed.