Trinitycore: [3.3.5] Little Exploit on Fiery Payback - Mage Fire Talent

[Keader]

To be possible to reproduce this "exploit", there must be lag (100~150 ms)
To have lag on the local host (Aokromes suggested use Valgrind tool).

Talent Description: When below 35% health all damage taken is reduced by 20% and your Pyroblast spell's cast time is reduced by 3.5 secs while the cooldown is increased by 5 secs.

Problem: By clicking multiple times quickly in Pyroblast, you can cast several times Pyroblast before the 5 second cooldown be applied.

Vid: https://youtu.be/B6WVnmplwa8

Trinity Hash: 9a43dd35cdd40228db5b8519b53ca5b6438c3c18

[ghost]

Related (but slightly different) issues:
[3.3.5] Fiery Payback mage talent #15157
Fire mage talent BUG [Fiery Payback] #9281 (Closed issue)

[Keader]

@mik1893 do you have any idea?

[mik1893]

I distinctly remember this bug.... but the way i solved it back in time was so ugly i would not really want to post it here (counting consecutive executions of pyroblast and prevent more than 1 every x ms...)
I had no idea at the time of the spell system (not that I probably have now, but at least i can understand most of where things happen...)

[Keader]

when you have free time, can you take a look on this @ariel- ?

[ariel-]

Is it still an issue?

[Keader]

I have not noticed anything that should fix it.

[ariel-]

The cooldown handling updates for example

[dexteerz]

Nothing about?

[Keader]

Closing...
I cant prove/test in current revs if this issue is still valid.

[Eliminationzx]

Issue still valid.
Tested rev https://github.com/TrinityCore/TrinityCore/commit/aa7ef797d6c362710a38c12e31db4b8f3b2963e4

I guess SPELLMOD_COOLDOWN has a little delay.

[ariel-]

Do you have any valid repro steps?

[Eliminationzx]

Same as on this vid https://youtu.be/B6WVnmplwa8

[Keader]

ahh ariel-...
you make it so easy to love you 😍