Trinitycore: Scripts/Quest: The Exorcism of Colonel Jules (30$ bounty)

[Killyana]

rev. f50df7282018
Original script: https://github.com/TrinityCore/TrinityCore/commit/95c07b627037ba63acad51012092e43f9532f61b
Many issues must be fixed:

• [ ] Remove the npcflag (has gossip_menu) for Colonel Jules and Anchorite Barada once the script starts.
• [ ] Change the emote state to drowned (383) once Colonel Jules starts moving around.
• [x] Fix the credit quest
• [ ] Anchorite Barada must walk and not run when he starts the waypoint.
• [x] Fix the spell Effect (Prayer Beads) on 22507 and 22506 (probably an instakill effect)
• [x] Fix the model of Colonel Jules as sometimes he spawns as a female
• [ ] improve spawn position for 22507 and 22506
• [ ] Despawn 22507 and 22506 if the player or Anchorite Barada dies
• [x] Fix the InhabitType of Colonel Jules
• [x] Fix tragets for the spell Prayer Beads
• [x] Fix gossip menu text for Colonel Jules
• [x] Fix spell effect of Prayer Beads on Anchorite Barada
• [x] Fix Crash http://paste.ubuntu.com/14588805/ http://pastebin.com/pvXnTihg

UPDATE `creature_template` SET `InhabitType`=4 WHERE `entry` IN (22432);
DELETE FROM `conditions` WHERE `SourceTypeOrReferenceId`=17 AND `SourceEntry`=39371 AND `ElseGroup`>0;
INSERT INTO `conditions` (`SourceTypeOrReferenceId`, `SourceGroup`, `SourceEntry`, `ElseGroup`, `ConditionTypeOrReference`, `ConditionTarget`, `ConditionValue1`, `ConditionValue2`, `ConditionValue3`, `Comment`) VALUES
(17, 0, 39371, 1, 31, 1, 3, 22507,0, "Ritual Prayer Beads"),
(17, 0, 39371, 2, 31, 1, 3, 22506,0, "Ritual Prayer Beads");

DELETE FROM `gossip_menu` WHERE `entry`=8554 AND `text_id`=10707;
INSERT INTO `gossip_menu` (`entry`,`text_id`) VALUES (8554,10707);
DELETE FROM `conditions` WHERE `SourceTypeOrReferenceId`=14 AND `SourceGroup`=8554;
INSERT INTO `conditions` (`SourceTypeOrReferenceId`,`SourceGroup`,`SourceEntry`,`ElseGroup`,`ConditionTypeOrReference`,`ConditionValue1`,`ConditionValue2`,`ConditionValue3`, `ErrorTextId`,`ScriptName`,`Comment`, `NegativeCondition`) VALUES
(14,8554,10706,0,28,10935,0,0,0,'',"Show gossip text if 'The Exorcism of Colonel Jules' is completed",0),
(14,8554,10706,1,8,10935,0,0,0,'',"Show gossip text if 'The Exorcism of Colonel Jules' is rewarded",0),
(14,8554,10707,1,28,10935,0,0,0,'',"Show gossip text if 'The Exorcism of Colonel Jules' is not completed",1),
(14,8554,10707,1,8,10935,0,0,0,'',"Show gossip text if 'The Exorcism of Colonel Jules' is not rewarded",1);

DELETE FROM `spell_linked_spell` WHERE `spell_trigger` = 39371;
INSERT INTO `spell_linked_spell` VALUES (39371, 39322, 0, 'Heal Anchorite Barada');

[DDuarte]

A bounty ($10) has just been posted on this issue by fallenoak.

[jackpoz]

Nice to see these fixes, are they already in 335 ?

[Killyana]

No, MitchesD still working on it.

[djbeauchamp]

The bounty increased.

https://www.bountysource.com/issues/26276849-3-3-5-6-x-quest-the-exorcism-of-colonel-jules

[jackpoz]

The crash has most likely been fixed but not the cause of why Colonel should fall below the ground

[SnapperRy]

Updated with current issues.

Also, can't get the emotestate drowning working... it's somehow removed on movement.

[killerwife]

The emotestate is related to a spell used on him afaik.

[jerbookins]

Quest does work. There are way, way, way too many Darkness Released mobs being spawned. There's no way to keep up without more people participating in the quest. c5fa08afc1d1

[illfated]

Did you follow all the tips in the comments on the wowhead page https://www.wowhead.com/quest=10935/the-exorcism-of-colonel-jules#comments to see if that makes it any easier? Or could there be some kind of double calls of summon spells (unless you specifically get that double spawn issue you had a year ago due to game client addons) ?

[jerbookins]

I can spam AoE to kill them, but as a hunter I just almost get one shot by them because of how many there are. The quest item that hurts them requires two shots to kill them when I remember it taking one. And there are some youtube videos that show some kind of holy nova spell being used (I don't know if that's a modification on a private server).

[illfated]

Looks like you have got a point there, even if the issue post lists this:

• [x] Fix the spell Effect (Prayer Beads) on 22507 and 22506 (probably an instakill effect)

Would be useful to hear from someone else testing this if they experience the same problem.

[AvatarStark]

i can do this quest blizzlike, but in lua

[Killyana]

Spells must bee used to summon npcs.
This not a fix
``` diff
diff --git a/src/server/scripts/Outland/zone_hellfire_peninsula.cpp b/src/server/scripts/Outland/zone_hellfire_peninsula.cpp
index 3ee81e7319..50eed396ca 100644
--- a/src/server/scripts/Outland/zone_hellfire_peninsula.cpp
+++ b/src/server/scripts/Outland/zone_hellfire_peninsula.cpp
@@ -444,13 +444,14 @@ public:

enum ExorcismSpells
{

• SPELL_JULES_GOES_PRONE = 39283,
• SPELL_JULES_THREATENS_AURA = 39284,
• SPELL_JULES_GOES_UPRIGHT = 39294,
• SPELL_JULES_VOMITS_AURA = 39295,
  -
• SPELL_BARADAS_COMMAND = 39277,
• SPELL_BARADA_FALTERS = 39278,
• SPELL_JULES_GOES_PRONE = 39283,
• SPELL_JULES_THREATENS_AURA = 39284,
• SPELL_JULES_GOES_UPRIGHT = 39294,
• SPELL_JULES_VOMITS_AURA = 39295,
• SPELL_JULES_SUMMON_FOUL_PURGE = 39302,
  +
• SPELL_BARADAS_COMMAND = 39277,
• SPELL_BARADA_FALTERS = 39278,
  };

enum ExorcismTexts
@@ -506,9 +507,6 @@ enum ExorcismEvents
{
EVENT_BARADAS_TALK = 1,
EVENT_RESET = 2,
-

• //Colonel Jules
• EVENT_SUMMON_SKULL = 1,
  };

/*######
@@ -560,7 +558,6 @@ public:

             success = false;

• events.ScheduleEvent(EVENT_SUMMON_SKULL, 10s);
  break;
  case ACTION_JULES_FLIGHT:
  me->RemoveAura(SPELL_JULES_GOES_PRONE);
  @@ -576,7 +573,6 @@ public:
  me->SetSpeedRate(MOVE_RUN, 1.0f);
  me->GetMotionMaster()->MovePoint(11, exorcismPos[2]);

• events.CancelEvent(EVENT_SUMMON_SKULL);
  break;
  }
  }
  @@ -597,8 +593,7 @@ public:

       if (id == 8)
       {
  

• for (uint8 i = 0; i < 2; i++)
• DoSummon(NPC_FOUL_PURGE, exorcismPos[8]);

• DoCast(SPELL_JULES_SUMMON_FOUL_PURGE);
  }

       if (id == 10)
  

  @@ -618,21 +613,6 @@ public:
  }

       events.Update(diff);
  

  -

• while (uint32 eventId = events.ExecuteEvent())
• {
• switch (eventId)
• {
• case EVENT_SUMMON_SKULL:
• uint8 summonCount = urand(1, 3);
  -
• for (uint8 i = 0; i < summonCount; i++)
• me->SummonCreature(NPC_DARKNESS_RELEASED, me->GetPositionX(), me->GetPositionY(), me->GetPositionZ() + 1.5f, 0, TEMPSUMMON_MANUAL_DESPAWN);
  -
• events.ScheduleEvent(EVENT_SUMMON_SKULL, 10s, 15s);
• break;
• }

• }
  }

   bool GossipHello(Player* player) override
  

[Jildor]

Aura: 39284 Hellfire - The Exorcism, Jules threatens
do:

Trigger spell (39280) Hellfire - The Exorcism, Jules threatens. Chance = 101

every 2 seconds

Spell ID - 39280 Hellfire - The Exorcism, Jules threatens
do:

Effect 1: Id 64 (SPELL_EFFECT_TRIGGER_SPELL)
BasePoints = 1
Targets (1, 0) (TARGET_UNIT_CASTER, NO_TARGET)
Trigger spell (39305) Not found, Chance = 101

and 39305 - Serverside - Summon Flying Skull
do summon npc = 22507

so every 2 seconds is summoning a skull and a lot of npcs are summoned

the script summon skulls too, so the serverside spell (39305) is needed??

[funjoker]

@fallenoak @bumbummen99 @djbeauchamp make sure to redeploy or withdraw your bounty. New TOS of bountysource will "steal" your money if you dont do so.

[bumbummen99]

@funjoker Thank you for the heads up! 👍

[jackpoz]

@Killyana are the known fixes in 335 branch ?

[Killyana]

No there's still some issues