Trident: Storage Prefix can't start with Number

[UristMcMiner]

Describe the bug
After upgrading to 20.07.01 (from 20.04), Backends with storage prefixes starting with a number won't validate any more, leaving the backend in an unusable state with no (known) way to migrate away.

Environment
Provide accurate information about the environment to help us reproduce the issue.

• Trident version: 20.07.1
• Container runtime: Docker 19.3.13
• Kubernetes version: 1.18.10
• Kubernetes orchestrator: Rancher v2.4.8
• Kubernetes enabled feature gates:
• OS: Ubuntu 20.04
• NetApp backend types: ONTAP
• Other:

To Reproduce
Create backend with storage prefix starting with a number in 20.04, then upgrade to 20.07.1

Expected behavior
Storage prefix will be validated and backend is usable

Additional context
Add any other context about the problem here.

[gnarl]

Hi @UristMcMiner,

Which version of ONTAP are you using? We just verified that ONTAP 9.8 does not support volumes that begin with a number. Please verify that the volume in ONTAP actually starts with a number and provide the ONTAP version.

[gnarl]

Hi @UristMcMiner,

We are planning to release Trident 20.10.0 soon. Please provide additional details on this issue.

[UristMcMiner]

Hi @gnarl,

Sorry for my late response, here are the requested details:

The Volumes itself do not start with the prefix, they start with "trident_qtree_pool_*" (At least for the nas-economy driver).

"5s4lm" would be the prefix in this case, but trident rejects this (for existing backends also, sets them to failed) because it doesn't match the new/changed regex that was introduced.

For the version of ontap, we're using 9.6P2

edit: got these log entries for this error:

time="2020-11-12T15:33:03Z" level=error msg="Could not initialize storage driver." error="error validating ontap-nas-economy driver: driver validation failed: storage prefix may only contain letters/digits/underscore/dash and must begin with letter/underscore/dash" requestID=f9910f8c-87ac-411a-877b-f407060ff14a requestSource=Internal
time="2020-11-12T15:33:03Z" level=warning msg="Cannot terminate an uninitialized backend." backend= backendUUID=dbd43ebc-28e0-44d1-b0b7-fb958b714d39 driver=ontap-nas-economy requestID=f9910f8c-87ac-411a-877b-f407060ff14a requestSource=Internal state=failed

[sorcix]

We're seeing the same issue, backends are in failed state because our storage prefix starts with a number.

This seems an unnecessary check as our volume names are trident_qtree_pool_$PREFIX$NAME and not just $PREFIX$NAME.

In https://github.com/NetApp/trident/issues/455 the . character has been added, can we do the same with numbers?

[sorcix]

We're now running a fork with https://github.com/NetApp/trident/pull/505 as it seems to be the only way to make our volumes work again.

[gnarl]

Hi @sorcix,

Thanks for the update. We are planning to include a fix for this in the Trident v21.01 release.

[gnarl]

This will be fixed with commit cfda44 in the Trident v21.01 release.