Treestyletab: PLain Dark Theme not rendered correctly in 3.4.1

Created on 6 Mar 2020  路  5Comments  路  Source: piroor/treestyletab

Short description

Latest version doesn't render Plain Dark Theme properly

Steps to reproduce

  1. Start Firefox with clean profile on system with dark theme
  2. Install latest TST 3.4.1.
  3. Select Plain Dark theme in TST settings

Expected result

Tabs are displayed correctly in dark theme
See screenshot from 3.3.6 (after clean install)
screenshot_14

Actual result

Tabs are not in dark theme
See screenshot from 3.4.1 (after clean install)
screenshot_13

Environment

  • Platform (OS): Linux Mint 19.3 Cinnamon, Theme: Mint-Y-Dark
  • Version of Firefox: 73.0.1 (64-bit)
  • Version (or revision) of Tree Style Tab: 3.4.1
fixed

Most helpful comment

The commit f09654b2445ca484620f38e366ef60fab6bd9471 should fix this unstable coloring problem. After the commit, system's dark color mode is ignored, and you may need to choose the "Plain Dark" theme manually.

Here is the (re-defined) policy about color scheme of TST:

  • The system color mode of TST is enabled by default only on Linux. Firefox's default theme on Linux uses system colors, so we also need to use system colors on addon. On this environment, CSS media query based "dark mode" is not supported.
  • System color mode is disabled on Windows and macOS. Firefox's default theme on these environments are designed with Photon color scheme, and colors are switched to dark colors when the dark color mode is activated on the OS side. So, TST also does same thing - applies light colors by default, and applies dark colors on the dark color mode.

All 5 comments

This looks happen when the system color support is active. Could you try a workaround?: TST Options => For developers => Color scheme => Photon

I'm also affected by this issue.
Workaround worked for me just fine.

Workaround worked for me too.

The commit f09654b2445ca484620f38e366ef60fab6bd9471 should fix this unstable coloring problem. After the commit, system's dark color mode is ignored, and you may need to choose the "Plain Dark" theme manually.

Here is the (re-defined) policy about color scheme of TST:

  • The system color mode of TST is enabled by default only on Linux. Firefox's default theme on Linux uses system colors, so we also need to use system colors on addon. On this environment, CSS media query based "dark mode" is not supported.
  • System color mode is disabled on Windows and macOS. Firefox's default theme on these environments are designed with Photon color scheme, and colors are switched to dark colors when the dark color mode is activated on the OS side. So, TST also does same thing - applies light colors by default, and applies dark colors on the dark color mode.

TST 3.4.6 is now available via addons.mozilla.org, so I close this.

Was this page helpful?
0 / 5 - 0 ratings