Treestyletab: TST stops working after bug 1565170

[Fanolian]

Short description

Bug 1565170 - Disable toSource/uneval in non-chrome code

TST sidebar cannot be initiated after updating to Nightly 2020-01-10 build (20200110220030). It is regressed by bug 1565170 according to Mozregression.

Steps to reproduce

1. Start Nightly 2020-01-10 with clean profile.
2. Install TST.
3. Observe the TST sidebar.

Expected result

Sidebar shows the tabs.

Actual result

Sidebar keeps loading.

Environment

• Platform (OS): Win 10 1909
• Version of Firefox: Nightly 2020-01-10 build (20200110220030)
• Version (or revision) of Tree Style Tab: 3.3.2 and 3.3.2.9933.9933

[hbriese]

I'm having the same issue

Environment

• Platform (OS): Ubuntu 19.04 (5.3.0-26 kernel)
• Version of Firefox: 74.0a1 (2020-01-10)
• Version (or revision) of Tree Style Tab: 3.3.2

[myessail]

Same issue here,

Environment

Platform (OS): macOS Mojave 10.14.6
Version of Firefox: 74.0a1 (2020-01-10) (20200110220030)
Version (or revision) of Tree Style Tab: 3.3.2

[Fanolian]

Here are some error messages in Browser Console that are new after bug 1565170:
(You can only see them by enabling Show Content Messages from Browser Console's gear icon on top right)

ReferenceError: uneval is not defined                common.js:393:43
    log              moz-extension://8d6444a9-20be-4010-b9d3-f875215ff4e7/common/common.js:393
    reduce           self-hosted:303
    log              moz-extension://8d6444a9-20be-4010-b9d3-f875215ff4e7/common/common.js:392
    $log             moz-extension://8d6444a9-20be-4010-b9d3-f875215ff4e7/extlib/l10n.js:18
    updateSubtree    moz-extension://8d6444a9-20be-4010-b9d3-f875215ff4e7/extlib/l10n.js:45
    updateDocument   moz-extension://8d6444a9-20be-4010-b9d3-f875215ff4e7/extlib/l10n.js:51
    <anonymous>      moz-extension://8d6444a9-20be-4010-b9d3-f875215ff4e7/extlib/l10n.js:56
    (Async: EventListener.handleEvent)
    <anonymous>      moz-extension://8d6444a9-20be-4010-b9d3-f875215ff4e7/extlib/l10n.js:55
    InnerModuleEvaluation        self-hosted:1605
    InnerModuleEvaluation        self-hosted:1594
    evaluation       self-hosted:1559

TypeError: this.$TST is undefined             TabElement.js:158:13
    initializeContents      moz-extension://8d6444a9-20be-4010-b9d3-f875215ff4e7/sidebar/components/TabElement.js:158
    _onOverflow             moz-extension://8d6444a9-20be-4010-b9d3-f875215ff4e7/sidebar/components/TabLabelElement.js:135
    _onOverflow             self-hosted:876
    (Async: EventListener.handleEvent)
    _startListening         moz-extension://8d6444a9-20be-4010-b9d3-f875215ff4e7/sidebar/components/TabLabelElement.js:119
    connectedCallback       moz-extension://8d6444a9-20be-4010-b9d3-f875215ff4e7/sidebar/components/TabLabelElement.js:60
    define                  moz-extension://8d6444a9-20be-4010-b9d3-f875215ff4e7/sidebar/components/TabLabelElement.js:16
    init                    moz-extension://8d6444a9-20be-4010-b9d3-f875215ff4e7/sidebar/sidebar.js:122
    (Async: EventListener.handleEvent)
    <anonymous>             moz-extension://8d6444a9-20be-4010-b9d3-f875215ff4e7/sidebar/index.js:28
    InnerModuleEvaluation   self-hosted:1605
    evaluation              self-hosted:1559

[Etrit1]

I'm having the same issue. It's actually be having problems with the last few Nightly builds but, has always worked... eventually. Now, nadda.

I really don't understand why Mozilla keeps breaking addons. Yes, I know there are tons of addons and that Mozilla isn't responsible for them. But come on, there HAS to be a way to do adaptive code in addons OR for Mozilla to stop changing things that clearly were working fine and that those changes break addons.

[piroor]

Fixed by the commit f94995b.

[wsmwk]

It's actually be having problems with the last few Nightly builds but, has always worked... eventually. Now, nadda.

I really don't understand why Mozilla keeps breaking addons

You were broken because you are nightly, and hopefully you understand how nightly works. Nightly isn't a branch that gets testing - things break without warning. Also, sometimes the breakage is intentional - as in the present case documented at https://www.fxsitecompat.dev/en-CA/docs/2020/tosource-and-uneval-have-been-removed/ It's the nature of the beast.

[Etrit1]

Wait, nightly doesn't get any testing at all?
Wierd.

And thanks for the link to what changed.

I actually only was on Nightly because it ran better on my computer then
the standard build. Or at least used to. I hadn't used the standard in over
a year. I just switched back because of this problem though... Maybe the
issue I was having with standard was fixed by now.

On Sat, Jan 11, 2020, 3:30 AM Wayne Mery [e-mail] wrote:

It's actually be having problems with the last few Nightly builds but, has
always worked... eventually. Now, nadda.

I really don't understand why Mozilla keeps breaking addons

You were broken because you are nightly, and hopefully you understand how
nightly works. Nightly isn't a branch that gets testing - things break
without warning. Also, sometimes the breakage is intentional - as in the
present case documented at
https://www.fxsitecompat.dev/en-CA/docs/2020/tosource-and-uneval-have-been-removed/
It's the nature of the beast.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/piroor/treestyletab/issues/2456?email_source=notifications&email_token=AG34OYVP6YVS36UZX7LGSPTQ5GUWPA5CNFSM4KFQMNNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIV742A#issuecomment-573308520,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AG34OYWI5JJSIROIYE5OMQLQ5GUWPANCNFSM4KFQMNNA
.

[piroor]

Firefox Nightly is tested around itself based on automated tests, but complete addon compatibility is out of the scope. Addon authors including me may test their addons with Nightly and often update them until the version is released as a stable version.

"Nightly" was called "Minefield" officially in old days. Please remind that Nightly has higher risk than other channels.

[Movisivi]

Thank you for fixing this so quickly @piroor

[YodaEmbedding]

Fixed by the commit f94995b.

Another Nightly user here. Manually applying this patch fixes things, though my tabs now load within 20 seconds rather than 5 seconds. The commit doesn't seem to contain anything that would cause this so it's probably unrelated.

[jnachtigall]

Temporarily workaround for Nightly until the fix with 3.3.3 release gets published on AMO:

1. Go to about:config
2. Search for xpinstall.signatures.required and set it to false
3. Go to https://github.com/piroor/treestyletab/releases and click on the 3.3.3 xpi
4. Install

When the fix is available on AMO, do not forget to reset xpinstall.signatures.required

[timvisee]

Will it be kept up-to-date after this manual installation, or does this
disable the updater?

On January 13, 2020 16:59:01 jnachtigall [e-mail] wrote:

Temporarily workaround for Nightly until the fix with 3.3.3 release gets
published on AMO:
Go to about:config
Search for xpinstall.signatures.required and set it to false
Go to https://github.com/piroor/treestyletab/releases and click on the
3.3.3 xpi
Install
When the fix is available on AMO, do not forget to reset
xpinstall.signatures.required
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.

[jnachtigall]

Will it be kept up-to-date after this manual installation, or does this disable the updater?

I do not know. Anyway, I could not really work so i did it. I just overwrote the existing 3.3.2 so I'd think in worst case I'd have to reinstall from AMO that would again overwrite the manual installation.

[piroor]

Currently TST's unsigned builds have no update information. Then the auto-update feature of Firefox refers its default source (Mozilla Add-ons). If TST 3.3.4 or newer versions are published to AMO you'll get updated versions automatically.

[diox]

3.3.4 is now out on AMO.