Treestyletab: Tree style tab just doesn't work at all anymore

[ksze]

Short description

Tree style tab doesn't work after updating to version 2.4.8.

Steps to reproduce

NOTE: starting with a clean profile does not apply because this problem happens when updating the extension.

1. Start an existing Firefox with an existing profile with some existing windows and tabs, and existing TST (I'm not sure if I had 2.4.6 or 2.4.7 prior to updating)
2. Update TST to 2.4.8
3. The TST extension automatically reloads.

Expected result

TST reloads in a working state, with my tree restored.

Actual result

The TST sidebar opens, but it's just a white dot bouncing left and right on a gray background.

• Close the sidebar and reopen --> still the same bouncing white dot.
• Disable and re-enable the extension --> still the same bouncing white dot.
• Close and reopen Firefox --> still the same bouncing white dot.

Environment

• Platform (OS): Windows 10 Professional 64-bit Fall Creator Update Version 1709 (build 16299.192)
• Version of Firefox: Firefox 58.0.1 64-bit
• Version (or revision) of Tree Style Tab: 2.4.8

[ksze]

More details. It seems that TST 2.4.8 has broken behaviour with regards to containers. If I disable these extensions:

• Firefox Multi-Account Containers 5.0.1
• Context Plus 0.5.0

Then TST can reload and "works". HOWEVER it loses all my windows and containered tabs. Only a very limited number of them can be salvaged from Firefox's "Recently closed tabs" and "Recently closed windows".

And if I enable those extensions again, TST stops working (the tree disappears from the TST sidebar).

[DerGenaue]

Possible duplicate of #1735?

[ksze]

Maybe. Even the workaround described in #1735 seems not very reliable though; I had to retry it a couple of times for the tree to load. And then I get these ugly, red-dot borders around the elements in the tree. Is there a way I can get rid of those borders?

[piroor]

I've tried with these steps:

• Setup Firefox (Nightly 60.0a1)
• Install TST 2.4.7, FIrefox Multi-Account Containers 5.0.1, and Context Plus 0.5.0.
• Update TST to 2.4.8

But I couldn't reproduce any problem. There are possibly some more triggers around configs of those addons. @ksze Did you check "Always open in Default" for any domain, at the popup menu of Firefox Multi-Account Containers?

[ksze]

@piroor No, I don't have "Always open in Default" (or "Always open in ") checked for any domain.

[Zefling]

It's pretty recurrent, infinite loading like that.

[piroor]

For all: could you cooperate to research what happens when the "infinite loading" happens? Steps to research:

1. Start addon debugger and attach debugger for the "/sidebar/sidebar.html" page.
   Instructions: https://github.com/piroor/treestyletab/wiki/How-to-inspect-tree-of-tabs#how-to-inspect-the-sidebar
2. Choose "Console" tab in the remote debugger.
3. Focus to the command line at the bottom of the debugger window, and run gMetricsData.toString().

The last step reports a details of the initialization process successfully. If the sidebar is correctly loaded, the log will be:

total 2600 msec for 57 tabs
0: Loaded
632: init start
247: browser.tabs.query, configs.$loaded
570: applyStyle, waitUntilBackgroundIsReady and retrieveAllContextualIdentities
1: getEffectiveWindowCache start
12: (async) calculateDefaultSizes
5: (async) initializing contextual identities
2: (async) tabContextMenu.init
289: (async) getting kWINDOW_STATE_SCROLL_POSITION
396: getEffectiveWindowCache get {"cache":false}
6: getEffectiveWindowCache fail
402: (async) read cached sidebar contents
392: (async) getting registered addons and scroll lock state
153: rebuildAll (from scratch)
471: inheritTreeStructure: kCOMMAND_PULL_TREE_STRUCTURE
1: applyTreeStructureToTabs: start
0: applyTreeStructureToTabs: preparation
27: applyTreeStructureToTabs: attach/detach
11: applyTreeStructureToTabs: collapse/expand
1: inheritTreeStructure: applyTreeStructureToTabs
509: (async) inheritTreeStructure
0: start to listen events
49: apply configs
1117: (async) main
1103: (async) parallel initialization tasks
5: applying scroll position
30: init end

On the other hand, on such "infinite loading" case, the result will become too short and some part will be missing. So it helps me knowing what process failed on the case.

[RanHum]

I did what you've said and got this:

In "Select an iframe as the currently targeted document" selected sole "/sidebar/sidebar.html", idk why there is "background" in window title
I personally suspect there is something racy in FF WebExt tabs load code, sometimes TST loads normally, but most of the time - not

Edit: oh, didn't see this info already have been provided in other issues...

[piroor]

@RanHum Thanks a lot! Your log is quite similar to other logs from contributors, so they all may see same problem. Now this issue is quite same to #1735, so I close this as a duplicated. For further research, could you cooperate to collect detailed logs on the startup process? Steps to collect logs are:

1. Install debug build of TST: https://piro.sakura.ne.jp/xul/xpi/nightly/treestyletab-we-debug.xpi
2. Restart Firefox to reproduce the problem.
3. Start remote debugger for TST (instructions: https://github.com/piroor/treestyletab/wiki/How-to-inspect-tree-of-tabs#how-to-collect-debug-logs-of-tst )
4. Choose /sidebar/sidebar.html?... from the namespace selector of the remote debugger, and run a script log.logs.join('\n') in the console. Then you'll see recent 1000 logs, so please paste it to #1735.