Treestyletab: Vertigo theme: white background on the left of children tabs

[3c0]

Short description

The vertigo theme has a small cosmetic issue.

Steps to reproduce

1. Install TST.
2. Select the Vertigo theme in TST options.
3. Open a window with at least one child tab.

Expected result

There should be no white background on the left of children tabs.

Note that the screenshot of the Vertigo theme in TST options does not exhibit this cosmetic glitch:

Actual result

Environment

• Platform (OS): Windows
• Version of Firefox: 57.0
• Version (or revision) of Tree Style Tab: 2.2.11

[piroor]

Thanks! e1a71fc should fix this.

[3c0]

Fix confirmed 😎, closing issue.

[damat]

Hmm, I'm on the latest version of the Firefox and Tree Style Tab, but the issue is still presented. Checked the sources, there's no update from the commit mentioned above.
What should I do?

[3c0]

@damat We have to wait for @piroor to publish the next TST release that will contain this fix among others... 🏭 ⌚️ 👀

I have personally tested the fix e1a71fc by directly patching the xpi file, but it is a cumbersome process. 😫

[damat]

@3c0 , I've patched mine as well but ended up with corrupted extension =) Reinstalled it, and posted the question here =)
Thank you for the update! I'll wait patiently

[TheSweetLily]

You can download latest TST on Piro's website: http://piro.sakura.ne.jp/xul/xpi/nightly/

[damat]

@thesweetlily, I've tried but Firefox prevented the install: https://dl.dropboxusercontent.com/s/ujgc6f7sulmvj1j/shot_171123_171536.png

[TheSweetLily]

Ah, right.
If you use xpinstall.signatures.required you can allow the install, although I think it's disabled on the stable release version(?).

[3c0]

@damat As you patch the xpi file, its signature becomes invalid and so Firefox barks at you. If you use Firefox Nightly or Developer edition, you can set xpinstall.signatures.required to false in about:config, but I would advise against doing so for security reasons. ☠️

@TheSweetLily Either way, we would loose AMO extensions auto update feature, wouldn't we ?

[damat]

it doesn't work even when this setting is disabled

[damat]

@3c0, yep, I do understand the risks, so waiting patiently
Btw, the update is just awesome =)

[TheSweetLily]

"@TheSweetLily Either way, we would loose AMO extensions auto update feature, wouldn't we ?"
The addon auto-updates for me whenever Piro releases a new version for me. (Like from 2.2.9 > 2.2.10)

[3c0]

@TheSweetLily Even if you install a TST nightly build ?

What I meant is: if you install a nightly build of an xpi (outside of AMO), then you loose the auto-update feature of extensions installed via AMO.

[TheSweetLily]

Yeh, that's been the case for me.

[3c0]

@TheSweetLily It appears that you're right ! 😲 @piroor is mixing TST _nightly_ and _release_ channels... 🙁

Issue reported in #1610.

[3c0]

Similar glitch is back in version 2.4.6 :

[3c0]

Looks like it is somehow related to #1733. Adding this CSS snippet seems to fix it :

:root, #background {
  background: var(--tab-surface);
}

[damat]

Thank you, @3c0 !
I wasn't able to figure it out by myself =( But now it's fixed forever =)

[piroor]

Thanks! 5465877 should fix this.