Treestyletab: Tree lost on session restore after crash

[adavier]

Short description

When firefox crashes (or is killed) so that when reopened it brings up the about:sessionrestore page. When the session is restored on this page all structure is lost.

Steps to reproduce

1. Start Firefox with clean profile.
2. Install TST.
3. Open some tabs in a tree
4. Kill firefox process
5. Reopen Firefox
6. Restore all tabs on about:sessionrestore

Expected result

Tabs restored with original structure

\- B (collapsed)
C
\- D
E (selected)

Actual result

Tabs loose all structure

B 
C
D
E (selected)

Environment

• Platform (OS): Win 10 (1607)
• Version of Firefox: Firefox 57b7
• Version (or revision) of Tree Style Tab: 2.04

[piroor]

After research, I've realized that restored tabs in this case seems to lose its metadata. I think I need to restore tree from window's metadata for this case...

[piroor]

Window's metadata is not available for restored window from crash. Thus we need to rebuild tree based on metadata of each tab.

[piroor]

By recent commits, tree seems to be restored correctly for tabs restored from crash.

[adavier]

In V 2.0.5 the trees do indeed successfully restore now. However it does not remember if a tree was collapsed or not - but this is very nitpicky as they can easily be collapsed manually.

[piroor]

However it does not remember if a tree was collapsed or not

Because the state is not stored for now. e34d6c4cfad3b517f5d38824342459a53f5d920f should fix this point.

[SimonSapin]

I just lost the tree structure of my tabs with TST 2.3.0 and Firefox 57.0.1.

I have profile backups, is there any chance to restore tree structure from that?

[SimonSapin]

Never mind, simply restarting Firefox restored everything :)

[madduck]

For me it happens not when I restart the browser, but if the browser dies (i.e. the laptop runs out of power) and then i start it again and restore the session, the entire tree structure is gone. This is using FF58 with the TST 2.4.8

[polyzen]

Duplicate of #1464

[sboddy]

Definitely not fixed yet. TST 2.4.16 and Firefox 58.0.2 on Ubuntu 16.04. Five pinned tabs, ~130 tabs below. Degree of nesting does not seem to make a difference. If I do not exit Firefox explicitly (i.e. FF crash, session crash, deliberate shutdown, etc) I lose the structure as described in the original comment. Get the usual "Would you like to restore?" and clicking the Restore button recovers all tabs, but now with the flat hierarchy.

[sboddy]

Further information I just spotted. After having a crash and restoring resulting in a flattened tree. I can quit FF, and restart it again, and the pre-crash structure is restored. So that is a workaround, but confusing and not friendly for people if you don't know about it. People could waste a lot of time re-nesting things.

[polyzen]

@sboddy, perhaps disabling/re-enabling TST would have the same effect as restarting Ff in this case.

[sboddy]

Yes, @polyzen you are right. A simple hide of the sidebar, and then a show (using the toolbar icon) causes the structure to come back. So it's just an annoyance rather than a full-blown bug when the recovery initially shows a flattened tree.

[talljosh]

I am experiencing a related issue on FF 58.0.2 on Ubuntu 16.04. Restarting Firefox after a power failure has resulted in not a flat tree, but a tree that's missing a whole bunch of open tabs. I can still switch to the tabs by typing bits of their title in the location bar, but they're not visible anywhere in the tab tree.

[ssokolow]

Still not fixed. I've had this happen to me twice in the last week with Firefox Developer Edition 60.0b4 and TST 2.4.17. (Most recently, a few minutes ago)

...and I'm pretty sure my structure is gone, because I didn't know any better and started middle-clicking new links. At the very least, closing and reopening the sidebar doesn't change anything now.

If it weren't for Multiple Tab Handler to quickly re-create the basic groups, I'd have already given up on TST.

That said, even with Multiple Tab Handler, it's still extremely frustrating because of various bugs in MTH. (It loves to replace "drag selected tabs into new parent" with "defer the context menu until I actually try to drag something, then display a brief flicker of it" or "deselect group and select what I attempted to drag" and I've had it occasionally skip tabs when dragging a selection. My kingdom for a "Group selected tabs" entry in the context menu it displays when I release a successful drag!)

(Given the frustration involved, my current plans are to move all of my persistent session information into an external store of my own (which combines SQLite and heavy use of automated testing), resulting in never having more than a dozen or so tabs open, and then rely on TST purely as an easy way to "Bookmark this Tree..." whenever I get carried away middle-clicking YouTube's related sidebar.)

EDIT: ...and now I've found about the off-by-default "Create New Group" option... after I already went to the trouble of manually grouping everything. This isn't my day.

[piroor]

I close this because outdated.