Transloco: Add Locale Support

[philjones88]

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[x] Support request
[ ] Other... Please describe:

Current behavior

No way to change LOCALE_ID based on language selected in transloco so that pipes such a Date etc update.

Expected behavior

Have some pipes like found in https://github.com/robisim74/angular-l10n

Minimal reproduction of the problem with instructions

For bug reports please provide the _STEPS TO REPRODUCE_ and if possible a _MINIMAL DEMO_ of the problem, for that you could use our stackblitz example

What is the motivation / use case for changing the behavior?

Environment

Angular version: X.Y.Z


Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX

For Tooling issues:
- Node version: XX  
- Platform:  

Others:

[itayod]

Hi @philjones88, thanks for your suggestion.

We will provide an external module that will include support for locales pipes (e.g. date format & currency) as part of Transloco.

[armanozak]

Hi @itayod, Hi @NetanelBasal,

May I suggest an alternative to creating copies of existing pipes in Angular? Take a look at this:

https://github.com/armanozak/angular-dynamic-locale

I had built this a few months ago for NgxTranslate, before I found out about Transloco. In my current project, I have implemented the same for Transloco and it appears to be working.

Would you like me to create a pull request for it?

[itayod]

Hi @armanozak, thanks for the suggestion.
I already implement it using the native JS API, and will release it next week.

[NetanelBasal]

@philjones88 we're almost there. @itayod will fix the PR comments, and we'll release the library.

We would love to get your feedback before the release. Here's the README file.

CC @armanozak.

[armanozak]

@itayod did an amazing job. Can't wait to give it a try. I've put a few comments. Hopefully useful ones... 🤞

[TmrdShnb]

‫في الجمعة، 13 سبتمبر 2019 في 12:25 ص تمت كتابة ما يلي بواسطة ‪Levent
Arman Özak‬‏ <‪[email protected]‬‏>:‬
>

Hi @itayod, Hi @NetanelBasal,

May I suggest an alternative to creating copies of existing pipes in Angular? Take a look at this:

https://github.com/armanozak/angular-dynamic-locale

I had built this a few months ago for NgxTranslate, before I found out about Transloco. In my current project, I have implemented the same for Transloco and it appears to be working.

Would you like me to create a pull request for it?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.