Tools: Add GitHub actions aws test workflow to template

Created on 27 Mar 2020  路  5Comments  路  Source: nf-core/tools

The aws test GitHub actions workflow should be added to the template

  • [x] Small CI tests on push to master
  • [x] Big tests triggered by a bot
  • [x] Docs on how to add big datasets

Most helpful comment

Hi @nf-core/core,
thinking about it I'm a bit hesitant about adding the AWS full test GitHub actions trigger on a comment to issues. In this case, anyone could trigger AWS full size tests by just adding this keyword to an issue, even if they are not part of nf-core.

There is also the option of triggering it on comments to pull requests only when they are opened (and not synchronized), but that doesn't really solve the problem as anybody part of the nf-core organization still can open a pull request.

I think still on push to master would be the safest option to trigger the workflow, and maybe also after a release to have the final results.

All 5 comments

Hi @nf-core/core,
thinking about it I'm a bit hesitant about adding the AWS full test GitHub actions trigger on a comment to issues. In this case, anyone could trigger AWS full size tests by just adding this keyword to an issue, even if they are not part of nf-core.

There is also the option of triggering it on comments to pull requests only when they are opened (and not synchronized), but that doesn't really solve the problem as anybody part of the nf-core organization still can open a pull request.

I think still on push to master would be the safest option to trigger the workflow, and maybe also after a release to have the final results.

Sure! I guess if we wanted we could always check if the comment came from someone in the nf-core/core team? But I鈥檓 pretty happy with just doing it on push to master & release. That鈥檚 still basically pre-release and release which is a lot.

As discussed via slack, the pre-release full tests can be done via Nextflow tower launch. The same queues, S3 bucket and AWS credentials can be specified there, and it should also launch the tests.

Solved in #620

image

Was this page helpful?
0 / 5 - 0 ratings

Related issues

drpatelh picture drpatelh  路  6Comments

ewels picture ewels  路  5Comments

matq007 picture matq007  路  7Comments

orzechoj picture orzechoj  路  3Comments

drpatelh picture drpatelh  路  7Comments