Tools: removing node_modules

Created on 27 Feb 2020 · 3Comments · Source: rome/tools

as node_modules is from history I don't think creating PR is easy . However I think we should add node_modules to gitignore ?

I used the following command to remove entire node modules from git history

find . -name node_modules -print0 | xargs -0 git rm -rf --ignore-unmatch

I did made a fork which address this issue.
https://github.com/shirshak55/rome/

I think pushing node_module is not intentional right?

Source

shirshak55

Most helpful comment

Yeah pushing node_modules is deliberate. The dependency list is extremely small and only for development. I'll leave this open since I'm sure this question will come up more.

sebmck on 27 Feb 2020

👍38 👎1

All 3 comments

in the Contributing.md file they have mentioned that they push the node_modules to GitHub intentionally.

No dependency installation step is required as we check in our node_modules folder that contains only a copy of TypeScript and some definitions.

itaditya on 27 Feb 2020

Yeah pushing node_modules is deliberate. The dependency list is extremely small and only for development. I'll leave this open since I'm sure this question will come up more.

sebmck on 27 Feb 2020

👍38 👎1

Shouldn't there be a note in the README about the node modules being under a different license? For instance, typescript has its own ThirdPartyNoticeText.txt