Tools: Link to Slack pipeline channel broken in README

Created on 10 Oct 2019  路  9Comments  路  Source: nf-core/tools

In main README.md

For further information or help, don't hesitate to get in touch on [Slack](https://nfcore.slack.com/channels/{{ cookiecutter.name }}) (you can join with this invite).

On pipeline creation this should evaluate to e.g.:

For further information or help, don't hesitate to get in touch on [Slack](https://nfcore.slack.com/channels/chipseq) (you can join with this invite).

instead of:

For further information or help, don't hesitate to get in touch on [Slack](https://nfcore.slack.com/channels/nf-core/chipseq) (you can join with this invite).
documentation first-timers-only

Most helpful comment

let me fix it for you guys .. PR coming up shortly

All 9 comments

{{ cookiecutter.name }} should be chipseq, right?

Yep :+1:

OK, then it's not my fault :-D
Because I do believe I'm the one that introduced this direct channel address in template.

Also needs to be fixed in this file CONTRIBUTING.md

For further information/help, please consult the [{{ cookiecutter.name }} documentation](https://github.com/{{ cookiecutter.name }}#documentation) and don't hesitate to get in touch on the [{{ cookiecutter.name }} pipeline channel](https://nfcore.slack.com/channels/{{ cookiecutter.name }}) on Slack.

let me fix it for you guys .. PR coming up shortly

Need some help here. since cookiecutter.name is dynamically evaluated and looking at the code . i believe the the change should be happening here self.name = 'nf-core/{}'.format(self.short_name) in __init__ method of PipelineCreate class. I will be removing the nf-core being appended to the short name. Please correct me if I am wrong

For further information/help, please consult the [{{ cookiecutter.name }} documentation](https://github.com/{{ cookiecutter.name }}#documentation) and don't hesitate to get in touch on the [{{ cookiecutter.name }} pipeline channel](https://nfcore.slack.com/channels/{{ cookiecutter.short_name }}) on Slack.

This should do it @GeniusStorm ! Thank you! Ill send you an invite as a contributor to if thats ok with you?

@drpatelh Sure you can send me the invite. I'll make that happen. Thanks

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ewels picture ewels  路  5Comments

sven1103 picture sven1103  路  4Comments

matq007 picture matq007  路  7Comments

lucacozzuto picture lucacozzuto  路  5Comments

apeltzer picture apeltzer  路  5Comments