Tools: --webserver-port option doesn't change the actual port

Created on 17 May 2017  路  3Comments  路  Source: Polymer/tools

I am using version 6.0.0 and when trying to change the webserver port using the --webserver-port argument is still remains 8081 as the default polymer serve port.

web-component-tester Medium Available Bug wontfix

Most helpful comment

Indeed, the port is not passed during server creation (https://github.com/Polymer/web-component-tester/blob/master/runner/webserver.ts#L136)

Also, even if the hostname looks like it's passed, localhost is hard coded : https://github.com/Polymer/web-component-tester/blob/master/runner/webserver.ts#L184
The hostname issue has already been reported and fixed in another branch : https://github.com/Polymer/web-component-tester/issues/523

@Polymer team : is there any impediments to merge the use-hostname branch into master ?

All 3 comments

Indeed, the port is not passed during server creation (https://github.com/Polymer/web-component-tester/blob/master/runner/webserver.ts#L136)

Also, even if the hostname looks like it's passed, localhost is hard coded : https://github.com/Polymer/web-component-tester/blob/master/runner/webserver.ts#L184
The hostname issue has already been reported and fixed in another branch : https://github.com/Polymer/web-component-tester/issues/523

@Polymer team : is there any impediments to merge the use-hostname branch into master ?

The new pr fixes the issue and ensure ensure that the correct default value is used when the user does not set the port.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

rasto68 picture rasto68  路  4Comments

stramel picture stramel  路  4Comments

pmaudsley picture pmaudsley  路  3Comments

lpellegr picture lpellegr  路  4Comments

ronnyroeller picture ronnyroeller  路  4Comments