Tools: [WCT] Browser Version mistake, when LAUNCHPAD variables are set

[fooloomanzoo]

If the environment variable e.g. LAUNCHPAD_CHROME is set (windows), it fails to look up the version number of chrome.
E.g.:

LAUNCHPAD_CHROME="C:\Program Files (x86)\Google\Chrome\Application\"

```
error: [cli.main] cli runtime exception: TypeError: Cannot read property 'match' of undefined
error: [cli.main] TypeError: Cannot read property 'match' of undefined
at chrome (C:\Users\Knecht Ruprecht\AppData\Roamingnpm\node_modules\polymer-cli\node_modules\wct-local\lib\browsers.js:110:36)
at Object. (C:\Users\Knecht Ruprecht\AppData\Roamingnpm\node_modules\polymer-cli\node_modules\wct-local\lib\browsers.js:84:38)
at Generator.next ()
at fulfilled (C:\Users\Knecht Ruprecht\AppData\Roamingnpm\node_modules\polymer-cli\node_modules\wct-local\lib\browsers.js:4:58)
at
at process._tickCallback (internal/process/next_tick.js:188:7)

problems are caused by this function:
```javascript
/**
 * @param browser A launchpad browser definition.
 * @return A selenium capabilities object.
 */
function chrome(browser, browserOptions) {
    return {
        'browserName': 'chrome',
        'version': browser.version.match(/\d+/)[0],
        'chromeOptions': {
            'binary': browser.binPath,
            'args': browserOptions || ['start-maximized']
        }
    };
}

The browser-Object does not contain a version entry.

[fooloomanzoo]

A simular issue exists for firefox. Setting launchpad-envirnment-variables (espeacially the paths of the browsers) could speed up the initial load time for running tests, see: https://github.com/bitovi/launchpad/issues/51

[jsilvermist]

Try using forward slashes instead?

[fooloomanzoo]

@jsilvermist No, this is just an example in markdown and not how it actually looks like. Fixed the example:

LAUNCHPAD_CHROME="C:\Program Files (x86)\Google\Chrome\Application\"

The object does not contain a version entry and so there can not be excecuted a regex-operation on a non-existing string

[hellokatili]

"bitovi/launchpad" tries to get the browser versions via resources/ShowVer.exe. The exec command in version.js in line 21 returns a "Permission denied" error.
Because there is no error handling in this step and WCT expects a version in the browser it is not possible to run any tests.

I didn't find a workaround so I can not test my Polymer components. 😞

[conceptree]

I have the same issues... it's really hard to get a proper test setup with Polymer wct structure. Is there a fix for this already?

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.