Tonic: Expose `set_nodelay` for server and channel

Created on 5 Nov 2019  路  1Comment  路  Source: hyperium/tonic

We should expose the hyper set_nodelay option as a config option for the transport channel and server.

crattonic enhancement good first issue
Source
picture LucioFranco

Most helpful comment

Hi,

I've made a PR #120 once I learned that my problem with abnormal latencies was caused by tokio defaulting to non-TCP_NODELAY sockets.

I did not make TCP_NODELAY a configuration option, though. It is required for services that exchange small requests, and adds no overhead in services that exchange bigger messages. I believe it makes sense to enable TCP_NODELAY unconditionally.

picture dominiquelefevre on 6 Nov 2019
👍3

>All comments

Hi,

I've made a PR #120 once I learned that my problem with abnormal latencies was caused by tokio defaulting to non-TCP_NODELAY sockets.

I did not make TCP_NODELAY a configuration option, though. It is required for services that exchange small requests, and adds no overhead in services that exchange bigger messages. I believe it makes sense to enable TCP_NODELAY unconditionally.

dominiquelefevre picture dominiquelefevre on 6 Nov 2019
👍3
Was this page helpful?
0 / 5 - 0 ratings

Related issues

ebkalderon picture ebkalderon  路  5Comments
LucioFranco picture LucioFranco  路  5Comments
pranjalssh picture pranjalssh  路  4Comments
blittable picture blittable  路  9Comments
rokadias picture rokadias  路  4Comments