I noticed that @schneiderl and @pxgamer added URL to a lot of pages, so I was wondering if it's a good idea to add one more check to the linter or just put one more checkbox on the PR message.
Ideas?
andrik
All 8 comments
I think it's worth adding them to the PR list. Regarding the linter, I'm not sure it's necessary unless we mark it as an optional thing.
owenvoke
on 14 May 2019
Hi,
We had a conversation starting from here on gitter a few days ago about this exact topic.
My feeling is that we should change the PR checklist and make the necessary changes to the style guide.
schneiderl
on 14 May 2019
Oh great, I'll close the issue and follow there :+1:
andrik
on 14 May 2019
Sounds great, @schneiderl!
Yeah, I'm not sure updating the linter right now is a good idea. Since it's an optional feature, I'm not sure we need to lint it.
If we were going to, then I think we'd need a new linter first (maybe using Nearley as I mentioned on the wiki).
sbrl
on 14 May 2019
If we did add it to the linter, it could be more of a lint to check it's the right format, rather than checking it exists.
owenvoke
on 14 May 2019
it could be more of a lint to check it's the right format
This is actually really good as I have seen commits with a wrong URL format happening (not once) here on tldr.
schneiderl
on 14 May 2019
Oh great, I'll close the issue and follow there 馃憤
I think this issue could remain open to track the addition of URL entry to the PR checklist and associated guidelines to the style guide.
waldyrious
on 14 May 2019
Ah, I see what you mean now @pxgamer - yeah!
sbrl
on 14 May 2019
Related issues
waldyrious
路
3Comments
zlatanvasovic
路
3Comments
schneiderl
路
3Comments
amitech
路
3Comments
hrai
路
3Comments
Most helpful comment
I think this issue could remain open to track the addition of URL entry to the PR checklist and associated guidelines to the style guide.