Tipsi-stripe: [Request] Please add types for Typescript

Created on 25 Mar 2020  路  8Comments  路  Source: tipsi/tipsi-stripe

wont-fix

All 8 comments

Duplication: https://github.com/tipsi/tipsi-stripe/pull/384

I'm using the type definitions of this PR by creating .d.ts file in my project.

I have created manually too but I'm sure with time it will be holding types that don't match the actual JS API of this package. :/

Yes sure. Official type definitions are much better.

There are no reasons for them to match the actual js API without having some way to test it, which requires a test demo application in TS.
If someone can do that - probably we could merge it after that.

You mean there should be a demo project written in TypeScript to merge the PR?
If so, I'll try to create it.

Yes, @acro5piano . Demo app in TS + TS definitions.

Which are you expecting?

Probably the second variant.
It should use max number of methods and should assemble for android and ios platforms without lot of steps.

Was this page helpful?
0 / 5 - 0 ratings