Tippyjs: Improve CI infrastructure

Created on 23 Oct 2019  Â·  9Comments  Â·  Source: atomiks/tippyjs

Remaining:

  • Type tests
  • Build tests (build/ files), especially the UMD versions

All 9 comments

Sounds like fun. I can definitely take a look on automating those processes.

Maybe we can even use GitHub Actions for this. I've only used Jenkins so far, so this will be interesting to learn.

Travis seems to have disappeared on GitHub UI but it's still running in the background

edit: nvm, fixed it I think

I've added image snapshot tests for the next branch (thanks to @FezVrasta I copied lots of his setup 💜) however they're failing on CI by a few 0.3%-5% and I don't know why. I think it might be due to the text rendering on Linux vs Mac, but at the same time, I kind of need to test text color for the themes... I don't know how to access the diffs without uploading them to a service either to see why they're actually different, but it's probably the text.

I think we had that issue on Popper and we had to make it transparent.


Edit: OK, I copied the reporter to actually see the images. Removing the text reduced the % but there are fundamental rendering differences with the Linux Chromium it seems:

img

I'm also not comfortable reducing the threshold at which it will pass since the themes need to be pixel perfect (particularly for the arrow centering, with the way the CSS is set up)

You may setup a docker image to run the tests locally, so that the snapshots are identical on CI and locally.

I worked it out — the button styling on Linux is different, I used all: unset and they're passing now. The docker thing would be good but too complex for me to set up at the moment :-\

@KubaJastrz doesn't seem like release: v6.0.1 triggered a docs build?

@atomiks, it did. But you haven't provided the GITHUB_TOKEN variable in travis ui settings.
https://travis-ci.com/atomiks/tippyjs/jobs/295120942

Fixed 👀

Most of this is done now, can track the remaining work in the type test PR

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Kearsan picture Kearsan  Â·  3Comments

andrewckor picture andrewckor  Â·  4Comments

Wyzix33 picture Wyzix33  Â·  4Comments

Neill83 picture Neill83  Â·  3Comments

faroukcharkas picture faroukcharkas  Â·  4Comments