Tiny-slider: Warning about uses of preventDefault calls inside passive listener

Created on 29 Jan 2019 · 21Comments · Source: ganlanyuan/tiny-slider

__Issue description__: When swiping slider on mobile, browser leave warning in console:
Unable to preventDefault inside passive event listener invocation.

__Demo link/slider setting__: Default

_Tiny-slider version_: 2.9.1
_Browser name && version_: Chrome
_OS name && version_: Emulator/Android

The warning point to this method

        function onPanMove (e) {
            if (panStart) {
                var $ = getEvent(e);
                lastPosition.x = $.clientX;
                lastPosition.y = $.clientY;

                if (carousel) {
                    if (!rafIndex) { rafIndex = raf(function(){ panUpdate(e); }); }
                } else {
                    if (moveDirectionExpected === '?') { moveDirectionExpected = getMoveDirectionExpected(); }
                    if (moveDirectionExpected) { preventScroll = true; }
                }

                if (preventScroll) { e.preventDefault(); }
            }
        }

Source

tungtrinh

👍28

Most helpful comment

Adding preventScrollOnTouch: 'auto' to my options when calling tns fixed this issue for me.

petertoh on 15 Jul 2019

👍33 😕4

All 21 comments

:+1:

Eduruiz on 6 Feb 2019

karneaud on 10 Feb 2019

It's someone to help?

kriss145 on 13 Feb 2019

Came here to check for existing issues as we discovered the errors, too.

There is some initial work in https://github.com/ganlanyuan/tiny-slider/pull/357 to fix this.

leomelzer on 19 Feb 2019

+1 over here!

SuperSchek on 27 Mar 2019

jarod022 on 29 Mar 2019

Any update on this issue?

drjgray on 13 May 2019

!up still have error in console

lirfaum on 16 May 2019

jblacas on 21 May 2019

demyan1411 on 21 May 2019

amydepalma on 21 May 2019

savchukm on 23 Jun 2019

Adding preventScrollOnTouch: 'auto' to my options when calling tns fixed this issue for me.

petertoh on 15 Jul 2019

👍33 😕4

@petertoh thank you savior!

hmmhmmhm on 24 Dec 2019

preventScrollOnTouch: 'auto' didn't work for me, but preventScrollOnTouch: 'force' clears up the error. It seem like one of those should resolve the error until there is a permanent fix.