Tinacms: onLogin of TinacmsGithubProvider is no longer triggered

[c58]

Description

onLogin of TinacmsGithubProvider is no longer called when cms enabled.

Steps to reproduce

Just setup next.js + github exactly as it is in the guide: https://tina.io/guides/nextjs/github/initial-setup/
Click to "Edit this page" button

Expected result

The base branch should be checkout, the preview mode should be activated

Actual result

Preview mode is not activated and the branch is not checked out.

Environment

MacOS

Tinacms Package Versions

├── UNMET PEER DEPENDENCY @tinacms/core@^0.29.0
├── UNMET PEER DEPENDENCY @tinacms/fields@^0.29.0
├─┬ [email protected]
│ ├── UNMET PEER DEPENDENCY @tinacms/[email protected]
│ ├── UNMET PEER DEPENDENCY @tinacms/fields@^0.29.0
├─┬ [email protected]
├─┬ [email protected]
│ └─┬ [email protected]
├─┬ [email protected]
├─┬ [email protected]
│ ├── @tinacms/[email protected]
│ ├─┬ @tinacms/[email protected]
│ ├─┬ @tinacms/[email protected]
│ ├─┬ @tinacms/[email protected]
│ ├── @tinacms/[email protected]
│ ├── @tinacms/[email protected]
│ ├─┬ @tinacms/[email protected]
│ ├─┬ @tinacms/[email protected]
│ ├── @tinacms/[email protected]
│ ├── @tinacms/[email protected]
│ ├─┬ @tinacms/[email protected]
│ ├─┬ @tinacms/[email protected]
│ ├─┬ @tinacms/[email protected]

Tools

| Tool | Version |
| ------- | ------- |
| browser | chrome |
| os | macos |
| node | v12.18.3 |
| npm | 6.14.6 |

NOTES

I believe that this is a degradation because of this commit: https://github.com/tinacms/tinacms/commit/6580c8afa247e3d6a1beb9d7e4967b45c130fa1e

TinacmsGithubProvider calls github.checkout on a success authorization of a base branch with gihtub.branchName, and then checkout compares it with this.branchName and does nothing, which produces the bug.

[jd4d]

+1 this has been very confusing trying to spin up a new project locally.

EDIT: confirmed that updating TinaCMS packages to "0.33.0" fixes the issue I was seeing where clicking "Edit this site" doesn't set the TinaCMS object = enabled, and doesn't set the proper cookies for preview mode.

[dwalkr]

@all-contributors add @c58 for bugs

[allcontributors[bot]]

@dwalkr

I've put up a pull request to add @c58! :tada: