Tinacms: Media Manager list not being called after second delete

[patrickconroy]

Description

Hello. When deleting an item in the media list the first time it runs the list function as expected, but not the second time. media:list:start is not fired after a successful second delete.

Steps to reproduce

const media = {
    accept: '*',
    list: (options) =>
        new Promise((resolve) => {
            const _list = async () => {
                const items = await tinaUploadListRefresh({
                    ...options,
                });

                resolve(items?.data?.media_list ?? { items: [] });
            };
            _list();
        }),
    delete: (item) =>
        new Promise((resolve) => {
            const _delete = async () => {
                await deleteTinaUpload({
                    variables: { id: item.id },
                });

                resolve();
            };
            _delete();
        }),
    persist: (files) =>
        new Promise((resolve) => {
            const _add = async () => {
                const item = await addTinaUpload();

                resolve(item.data.tina_upload);
            };
            _add();
        }),
};
const cms = new TinaCMS({
    media,
});

Expected result

Whenever something's deleted it should re-list (in my opinion).

Actual result

First delete triggers a re-list, second does not.

Environment

Tinacms Package Versions

├─┬ [email protected]
├─┬ [email protected]
├─┬ [email protected]
├─┬ UNMET PEER DEPENDENCY [email protected]
│ ├── @tinacms/[email protected]
│ ├── @tinacms/[email protected]
│ ├─┬ @tinacms/[email protected]
│ ├─┬ @tinacms/[email protected]
│ ├─┬ @tinacms/[email protected]
│ ├── @tinacms/[email protected]
│ ├── @tinacms/[email protected]
│ ├─┬ @tinacms/[email protected]
│ ├─┬ @tinacms/[email protected]
│ ├── @tinacms/[email protected]
│ ├── @tinacms/[email protected]
│ ├─┬ @tinacms/[email protected]
│ ├─┬ @tinacms/[email protected]
│ ├─┬ @tinacms/[email protected]
├─┬ [email protected]
├─┬ [email protected]

Tools

| Tool | Version |
| ------- | ------- |
| browser | Chrome |
| os | Mac 10.15.7 |
| node | 14.5 |
| npm | 6.14.5 |

[patrickconroy]

After opening this I rearranged my setup (React code) to create my TinaCms instance only once in a useEffect, whereas before it was creating a new instance every render, and it works as expected now.