Timescaledb: 1.6.0: cannot find pg_isolation_regress.sh during bootstrap

[blair]

Relevant system information:

• OS: macOs High Sierra
• PostgreSQL version (output of postgres --version): 10.11
• TimescaleDB version (output of \dx in psql): 1.6.0
• Installation method: source

Describe the bug
A clear and concise description of what the bug is.
bootstrap fails:

~/tmp/timescaledb$ git clean -dfx
Removing build/
~/tmp/timescaledb$ ./bootstrap 
-- The C compiler identification is AppleClang 10.0.0.10001145
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- TimescaleDB version 1.7.0-dev. Can be updated from version 1.6.0
-- Build type is Release
-- Install method is 'source'
-- Performing Test CC_SUPPORTS_VISIBILITY_HIDDEN
-- Performing Test CC_SUPPORTS_VISIBILITY_HIDDEN - Success
-- Using compiler AppleClang
-- Found Git: /opt/local/bin/git (found version "2.25.0") 
-- Using pg_config /opt/local/bin/pg_config
-- Compiling against PostgreSQL version 10.11
-- Using local clang-format
-- Found OpenSSL: /opt/local/lib/libcrypto.dylib (found version "1.1.1d")  
-- Using OpenSSL version 1.1.1d
-- Using nm /opt/local/bin/nm
-- Using pg_regress /opt/local/lib/postgresql10/pgxs/src/test/regress/pg_regress
CMake Error at test/CMakeLists.txt:81 (message):
  Program 'pg_isolation_regress' not found, but regressions checks were
  required.

  Skip regression checks using -DREGRESS_CHECKS=OFF


-- Configuring incomplete, errors occurred!
See also "/tmp/blair/timescaledb/build/CMakeFiles/CMakeOutput.log".
~/tmp/timescaledb$ git describe 
1.1.0-655-g8f2d6b1d

Patch that fixes it:

diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
index d529a1f5..8e230478 100644
--- a/test/CMakeLists.txt
+++ b/test/CMakeLists.txt
@@ -9,8 +9,9 @@ find_program(PG_REGRESS pg_regress
   "${PG_PKGLIBDIR}/pgxs/src/test/regress/")

 find_program(PG_ISOLATION_REGRESS
-  NAMES pg_isolation_regress
+  NAMES pg_isolation_regress.sh
   HINTS
+  ${PRIMARY_TEST_DIR}
   ${BINDIR}
   ${PG_PKGLIBDIR}/pgxs/src/test/isolation
   ${PG_SOURCE_DIR}/src/test/isolation)

[svenklemm]

Hi,

pg_isolation_regress is a binary from postgres which does not get built in a normal postgres build, so you have to build it yourself if you want to run the isolation regression tests. If you dont want to do that you should run bootstrap with -DREGRESS_CHECKS=OFF. The pg_isolation_regress.sh script is just a wrapper to call that binary and not what cmake should be looking for.