Tilix: Bg: scaled, keeping ratio

[egmontkob]

Thanks for the background image support, it's really awesome!

Along with Scale/Tile/Center, I believe a great choice would be to crop along one axis only (centered) and scale keeping the aspect ratio.

(I guess this is what most phones/desktops do with background image.)

E.g. if the canvas is 500x300 and the picture is 1000x800 then it'd be scaled down to 500x400 and then the top and bottom 50+50px cropped.

[egmontkob]

Just wondering about the terminology to use... maybe Scale for this one, and rename the current Scale to Stretch?

[phw]

Or remove the existing scale completely? Is this really useful?

[gnunn1]

For the current Scale option, I'm vacillating between calling it Stretch or Fill.

@phw It's a fair point, some people though may like it from the point of view of having the terminal window completely filled.

[egmontkob]

FYI:

What I had in mind was to crop the image, so that whatever remains fills in the whole application window.

Displaying the entire picture, plus empty margins if necessary, is another viable option, but I like it less :)

Also, due to the (per-terminal) title bar, it _seems_ that the picture is not vertically centered. This is a bit distracting with margins, but probably far less noticeable if the image is cropped.

Thanks!

[gnunn1]

I missed the cropping part, I'l see what I can do.

[egmontkob]

It now crops from the left or from the top, rather than equally from both opposite sides (either from top and bottom, or from left and right). Probably a div by 2 missing. Just sayin :P

[gnunn1]

lol, with all the time spent on this background image feature I probably could have solved world hunger instead! Good thing it's been a fun feature to implement and it's been interesting learning more about Cairo.

Anyway, I'll have a look at this.

[egmontkob]

Not sure about you guys, but I like it a lot! Thanks! :)