Tiddlywiki5: Clearer warning for import overwrite

[twMat]

Upgrading a wiki from 5.1.19 to 5.1.21

...which tiddler actually? Can I even trust that it is only one tiddler? Is it maybe this top one here:

...but then, that second one (which I know I've overwritten) one is also a core tiddler as far as I know, or is that not considered a "core module tiddler" (as indicated by the name path)?

Proposal
The yellow popup should list which exact tiddlers it refers to and/or the import listing could colour the relevant entries with that same yellow background colour.

The proposal is really general: any system note referring to "tiddlers" should name the concerned tiddlers.

Related issues...
...posted merely to show that the UI is not quite clear - but, to keep the above issue defined and actionable, the following is NOT part of any request:

• Do core modules deal with particularly sensitive systemic matters or why am I being warned?
• That garbage can symbol... shouldn't it be a closing X symbol? What is there to delete? The popup? Dare I click it?
• Time stamp there - why?

[twMat]

Follow up: Having disregarded the popup (but not clicked the delete button), I did click upgrade and saved etc. On starting up the upgraded wiki, the popup has persisted. I did not expect this but I guess it might make sense. I'm just posting this to make sure it is the intended behaviour.

[pmario]

core modules are executables. That's the difference. The close-button is an icon, it can't create instability.

[pmario]

The yellow popup should list which exact tiddlers it refers to and/or the import listing could colour the relevant entries with that same yellow background colour.

IMO the dialogue should stay. The import table could use some color.

[pmario]

The proposal is really general: any system note referring to "tiddlers" should name the concerned tiddlers.

I think the dialogue is exact. It says "core module tiddler" the import table says: "Core module tiddler". IMO there isn't much more text that could be improved.

[twMat]

Thanks for replies.

I think the dialogue is exact. It says "core module tiddler" the import table says: "Core module tiddler". IMO there isn't much more text that could be improved.

There's a lot of scrolling to ensure you see which tiddlers are referred to. And would the dialogue say "tiddlers" if there were multiple?

Why is it not a good idea to list the referenced tiddlers in the popup?

[pmario]

Why is it not a good idea to list the referenced tiddlers in the popup?

Because it would be too big. And to be honest. Which users reads warning popups that are more then 3 lines long.

IMO The popup can be generic and the import table can have links to more info in a "per line" setting.

There is still the problem, what ever info you put there. It won't be good enough for some users.

[twMat]

IMO The popup can be generic and the import table can have links to more info in a "per line" setting.

Fair enough. Thanks for input.

[Jermolene]

Hi @twMat @pmario just for the record, this warning was introduced by @bimlas in #3634, and then updated by me in 471b73158a887d2f060194741739c1da8b5d44d8 to refine the logic so that the warning only appears when attempting to overwrite a core shadow tiddler whose title begins with $:/core/modules/.

I'm sympathetic to @twMat's original post. This warning message is scary and inscrutable, and there's no obvious route for a user to deal with the underlying issue.

One detail that I'm tempted to deal with now is to replace the "trash" icon in alerts with a more conventional "close" button.

[Jermolene]

One detail that I'm tempted to deal with now is to replace the "trash" icon in alerts with a more conventional "close" button.

It turns out that I had already done this as part of the fix-syncer PR in https://github.com/Jermolene/TiddlyWiki5/pull/4373/files#diff-e667d4ddace4e2915a25d431394e9c18

[twMat]

@Jermolene wrote

[...] and there's no obvious route for a user to deal with the underlying issue.

Do I recall talk about a diff comparison feature for import warnings? Otherwise this might be a good idea.

[Jermolene]

I think that the root cause of the problem is the use in #3634 of an alert instead of the usual mechanism of displaying the warning alongside the tiddler in question. Reverting to the standard mechanism would alleviate the problem, I think.