Tidb: admin check table fail on partitioned table in 3.0

Created on 4 Mar 2020 · 3Comments · Source: pingcap/tidb

Bug Report

Please answer these questions before submitting your issue. Thanks!

What did you do?
If possible, provide a recipe for reproducing the error.

use test;

create table if not exists forupdate_on_partition (
  age int not null primary key,
  nickname varchar(20) not null,
  gender int not null default 0,
  first_name varchar(30) not null default '',
  last_name varchar(20) not null default '',
  full_name varchar(60) as (concat(first_name, ' ', last_name)),
  index idx_nickname (nickname)
) partition by range (age) (
  partition child values less than (18),
  partition young values less than (30),
  partition middle values less than (50),
  partition old values less than (123)
);

admin check table forupdate_on_partition;

What did you expect to see?

No error

What did you see instead?

The error stack is

[2020/03/04 13:10:40.038 +08:00] [WARN] [conn.go:684] ["dispatch error"] [conn=1] [connInfo="id:1, addr:127.0.0.1:51497 status:10, collation:utf8_general_ci, user:root"] [command=Query] [status="inTxn:0, autocommit:1"] [sql="admin check table forupdate_on_partition"] [err="strconv.ParseUint: parsing \"\": invalid syntax
github.com/pingcap/errors.AddStack
    C:/project/pkg/mod/github.com/pingcap/[email protected]/errors.go:174
github.com/pingcap/errors.Trace
    C:/project/pkg/mod/github.com/pingcap/[email protected]/juju_adaptor.go:15
github.com/pingcap/tidb/planner/core.(*PlanBuilder).rewriteExprNode
    C:/project/src/github.com/pingcap/tidb/planner/core/expression_rewriter.go:143
github.com/pingcap/tidb/planner/core.(*PlanBuilder).rewriteWithPreprocess
    C:/project/src/github.com/pingcap/tidb/planner/core/expression_rewriter.go:111
github.com/pingcap/tidb/planner/core.(*PlanBuilder).rewrite
    C:/project/src/github.com/pingcap/tidb/planner/core/expression_rewriter.go:86
github.com/pingcap/tidb/planner/core.(*PlanBuilder).projectVirtualColumns
    C:/project/src/github.com/pingcap/tidb/planner/core/logical_plan_builder.go:2468
github.com/pingcap/tidb/planner/core.(*PlanBuilder).buildDataSource
    C:/project/src/github.com/pingcap/tidb/planner/core/logical_plan_builder.go:2350
github.com/pingcap/tidb/planner/core.(*PlanBuilder).buildResultSetNode
    C:/project/src/github.com/pingcap/tidb/planner/core/logical_plan_builder.go:155
github.com/pingcap/tidb/planner/core.(*PlanBuilder).buildJoin
    C:/project/src/github.com/pingcap/tidb/planner/core/logical_plan_builder.go:378
github.com/pingcap/tidb/planner/core.(*PlanBuilder).buildResultSetNode
    C:/project/src/github.com/pingcap/tidb/planner/core/logical_plan_builder.go:147
github.com/pingcap/tidb/planner/core.(*PlanBuilder).buildSelect
    C:/project/src/github.com/pingcap/tidb/planner/core/logical_plan_builder.go:2018
github.com/pingcap/tidb/planner/core.(*PlanBuilder).Build
    C:/project/src/github.com/pingcap/tidb/planner/core/planbuilder.go:271
github.com/pingcap/tidb/planner.Optimize
    C:/project/src/github.com/pingcap/tidb/planner/optimize.go:39
github.com/pingcap/tidb/executor.(*Compiler).compile
    C:/project/src/github.com/pingcap/tidb/executor/compiler.go:79
github.com/pingcap/tidb/executor.(*Compiler).SkipBindCompile
    C:/project/src/github.com/pingcap/tidb/executor/compiler.go:61
github.com/pingcap/tidb/session.(*session).execute
    C:/project/src/github.com/pingcap/tidb/session/session.go:1074
github.com/pingcap/tidb/session.(*session).Execute
    C:/project/src/github.com/pingcap/tidb/session/session.go:1018
github.com/pingcap/tidb/session.execRestrictedSQL
    C:/project/src/github.com/pingcap/tidb/session/session.go:768
github.com/pingcap/tidb/session.(*session).ExecRestrictedSQLWithSnapshot
    C:/project/src/github.com/pingcap/tidb/session/session.go:763
github.com/pingcap/tidb/util/admin.getCount
    C:/project/src/github.com/pingcap/tidb/util/admin/admin.go:267
github.com/pingcap/tidb/util/admin.CheckIndicesCount
    C:/project/src/github.com/pingcap/tidb/util/admin/admin.go:292
github.com/pingcap/tidb/executor.(*CheckTableExec).Next
    C:/project/src/github.com/pingcap/tidb/executor/executor.go:549
github.com/pingcap/tidb/executor.Next
    C:/project/src/github.com/pingcap/tidb/executor/executor.go:192
github.com/pingcap/tidb/executor.(*ExecStmt).handleNoDelayExecutor
    C:/project/src/github.com/pingcap/tidb/executor/adapter.go:435
github.com/pingcap/tidb/executor.(*ExecStmt).Exec
    C:/project/src/github.com/pingcap/tidb/executor/adapter.go:299
github.com/pingcap/tidb/session.runStmt
    C:/project/src/github.com/pingcap/tidb/session/tidb.go:251
github.com/pingcap/tidb/session.(*session).executeStatement
    C:/project/src/github.com/pingcap/tidb/session/session.go:980
github.com/pingcap/tidb/session.(*session).execute
    C:/project/src/github.com/pingcap/tidb/session/session.go:1094
github.com/pingcap/tidb/session.(*session).Execute
    C:/project/src/github.com/pingcap/tidb/session/session.go:1018
github.com/pingcap/tidb/server.(*TiDBContext).Execute
    C:/project/src/github.com/pingcap/tidb/server/driver_tidb.go:246
github.com/pingcap/tidb/server.(*clientConn).handleQuery
    C:/project/src/github.com/pingcap/tidb/server/conn.go:1205
github.com/pingcap/tidb/server.(*clientConn).dispatch
    C:/project/src/github.com/pingcap/tidb/server/conn.go:921"]

What version of TiDB are you using (tidb-server -V or run select tidb_version(); on TiDB)?

Current 3.0 branch

commit b93defa381c8de1e509a5c5ecdabdd07ad14e65b (HEAD, origin/release-3.0)
Author: pingcap-github-bot <[email protected]>
Date:   Tue Mar 3 16:36:41 2020 +0800

    test: fix data race in TestDisableTxnAutoRetry (#14825) (#14856)

severitmajor statuhelp-wanted typbug

Source

tiancaiamao

All 3 comments

As we can see from the pictures and the error stack, admin check table would call ExecRestrictedSQLWithSnapshot, it will use a session without MaxAllowedPacket, which lead to parseUint failure.