Three.js: ColorKeywords in Euler.d.ts

Created on 8 Aug 2019  路  5Comments  路  Source: mrdoob/three.js

Are the ColorKeywords supposed to be in Euler.d.ts?
https://github.com/mrdoob/three.js/blob/d41db0e13e26a610a04e5ff20a66c0a18faf216d/src/math/Euler.d.ts#L5-L14
Apparently they've been there since Euler.d.ts got imported. Shockingly, nothing in Euler references them.

Bug
Source
picture moraxy

Most helpful comment

@Mugen87

I have submitted a PR addressing this issue.
https://github.com/mrdoob/three.js/pull/17261

picture 97amarnathk on 15 Aug 2019
👍2

All 5 comments

I think you can just remove this namespace. Want to make a PR^^?

Mugen87 picture Mugen87 on 8 Aug 2019
👍1

@Mugen87 I would love to start in threeJS contributions with this. Can I have this issue assigned to me?

97amarnathk picture 97amarnathk on 12 Aug 2019
👍1

It seems @moraxy gave you a like so why not 馃槈

Mugen87 picture Mugen87 on 12 Aug 2019
👍1

Sure. I will try to do this by tomorrow. :)

97amarnathk picture 97amarnathk on 12 Aug 2019

@Mugen87

I have submitted a PR addressing this issue.
https://github.com/mrdoob/three.js/pull/17261

97amarnathk picture 97amarnathk on 15 Aug 2019
👍2
Was this page helpful?
0 / 5 - 0 ratings

Related issues

seep picture seep  路  3Comments
alexprut picture alexprut  路  3Comments
filharvey picture filharvey  路  3Comments
clawconduce picture clawconduce  路  3Comments
Horray picture Horray  路  3Comments