Three.js: PCD loader does not work in Microsoft Edge

[k0rzun1n]

PCD loader does not work in Microsoft Edge.
Works in Chrome.

[Mugen87]

Can you please check if this version is working on your system:

https://raw.githack.com/Mugen87/three.js/dev29/examples/webgl_loader_pcd.html

[k0rzun1n]

Checked.

SCRIPT5025: The URI to be decoded is not a valid encoding

[Mugen87]

Um, it seems the following line in LoaderUtils.decodeText() produces the runtime error:

https://github.com/mrdoob/three.js/blob/ba4069a20ac532b24d4007e959e86fd861feed04/src/loaders/LoaderUtils.js#L28

Just returning the variable s seems to solve the issue.

@donmccurdy #12934 introduced the usage of decodeURIComponent() and escape(). However, when I remove the usage of TextDecoder from LoaderUtils.decodeText() so the alternative code path is always used, I see the same error with other loaders. In Chrome, webgl_loader_ply reports an Uncaught URIError: URI malformed which is essentially the same error reported in Edge. It seems the current fallback does not properly handle all use cases.

@k0rzun1n Can you please verify if https://threejs.org/examples/webgl_loader_ply.html throws the same error on your machine?

[k0rzun1n]

@Mugen87 It does.

[donmccurdy]

12934 introduced the usage of decodeURIComponent() and escape() ...

Hm. That patch avoids failures when the string contains multi-byte characters, but introduces failures here. It was never a great fix for the former, but I don't know of another... should we just surround this in a try/catch?

try {

  return decodeURIComponent( escape( s ) );

} catch ( e ) {

  console.warn( 'THREE.LoaderUtils: Lorem ipsum...', e );

  return s;

}

Alternative solutions for multi-byte characters would be welcome, but be aware that character-by-character iteration may have performance implications.

[mrdoob]

This could also be solved by waiting for the Chromium-based Edge...?

[k0rzun1n]

Can we still get some crutch for all the cave people that won't update?

[Mugen87]

This could also be solved by waiting for the Chromium-based Edge...?

I think so. But adding a simple try/catch seems appropriate to me in order to make the current method more robust.

[Mugen87]

Ups, we totally missed #13764 😅

However, I think I vote for the try/catch solution since other loaders like PLYLoader will just work and do not need an enhancement.

[donmccurdy]

I prefer the try/catch over using an isASCII flag suggested in #13764. 👍

[k0rzun1n]

It still doesn't work though.

[Mugen87]

The fix is not in production yet. Can you please try it with the dev version?

https://raw.githack.com/mrdoob/three.js/dev/examples/webgl_loader_pcd.html

[k0rzun1n]

@Mugen87 SCRIPT5025: The URI to be decoded is not a valid encoding

[Mugen87]

The build files in dev were not updated yet, 81e184c73b29c1b07c8e9fc3904c5855a65d44ee

Please try it again.

[k0rzun1n]

Yeah, it works now.