Three.js: Uniforms-types page in the wiki is very out of date

Created on 3 Jan 2019  路  5Comments  路  Source: mrdoob/three.js

It hasn't been updated since 2014, but there have been quite a few changes since - in particular, "type" is no longer required.

https://github.com/mrdoob/three.js/wiki/Uniforms-types~~

Most helpful comment

I think this issue can be closed now since #10759 already tracks the enhancement of the documentation.

All 5 comments

When WebGLUniforms was introduced via #8606, Uniform.type was no longer necessary. WebGLRenderer now uses the information from the WebGLRenderingContext.getActiveUniform() call in order select the correct WebGL API method for specifying a value for a particular uniform. This means the renderer just needs the compiled shader program to derive the uniform type.

Because of this, I suggest to delete the entire wiki page. The existing documentation page about uniforms already covers the most important information:

https://threejs.org/docs/index.html#api/en/core/Uniform

We might want to enhance the documentation with a small guide about how to use structured uniforms, see #10759

@Mugen87 sounds good 馃憤

Okay, the page and the links to it are now gone.

I think this issue can be closed now since #10759 already tracks the enhancement of the documentation.

Sweet! Thanks @Mugen87 馃榿

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Horray picture Horray  路  3Comments

ghost picture ghost  路  3Comments

konijn picture konijn  路  3Comments

scrubs picture scrubs  路  3Comments

donmccurdy picture donmccurdy  路  3Comments