Three.js: Threejs 99: fbx skinned meshes have issues

Created on 2 Dec 2018 · 12Comments · Source: mrdoob/three.js

I've updated from threejs r96 to r99 and animated fbx meshes went all over the place.
The same fbx loader script is used in both cases.

Animated collada models seems fine.

r96:
https://lune.live/forums/3-96.png

r99
https://lune.live/forums/3-99.png

Source

pikilipita

Most helpful comment

@looeee Do you want to make the change for FBXLoader?

Looks like you beat me to it! 😅

looeee on 21 Dec 2018

😄2

All 12 comments

Can you please test if an additional line of code solves the issue? Please add the following line...

model.normalizeSkinWeights();

after this one:
https://github.com/mrdoob/three.js/blob/1cbcaab0b8c80cd66b5812881597529f9ebd19c0/examples/js/loaders/FBXLoader.js#L1233

Mugen87 on 2 Dec 2018

Thank you, that was fast!

it seems to have fixed the issue with fbx models made from blender,
but fbx models made from cinema4D are still experiencing issues.

pikilipita on 2 Dec 2018

but fbx models made from cinema4D are still experiencing issues

Do you also have issues with these models with R96?

Mugen87 on 2 Dec 2018

@mrdoob Would it be not better to call SkinnedMesh.normalizeSkinWeights() in all loaders that produce skinned meshes right now? I'm afraid we are going to have more support cases like this one...

Mugen87 on 2 Dec 2018

I also had issues on r96 when using the latest fbx loader, but different ones.

The only way I know to get a perfect Cinema4D fbx files in threejs is to use this combo:
r96 + an old fbx loader (back from April 2018)

pikilipita on 2 Dec 2018

Okay, thanks for the feedback! I think it makes sense to separate both problems. Can you please share in this thread one of the problematic FBX files exported from Cinema4D? I'm sure @looeee can have a look at it.

The issue about SkinnedMesh.normalizeSkinWeights() is something different.

Mugen87 on 2 Dec 2018

There seems to be quite a few reports if Cinema4D models being incorrect recently - maybe related to #15287 and #15097 and possibly happening since I switched to calculating transforms according to the spec in #14933.

@pikilipita could you check those issues and if your issues with the Cinema4D model seem related to those, post the model there?

Otherwise please make a new issue titled "Issues with Cinema4D FBX models" and include the model there.

looeee on 3 Dec 2018

👍1

Thanks, not too sure if they are related, as from my side I only see issues with animated models.
I created a new issue: #15358

pikilipita on 3 Dec 2018

I test on r99 + fbx loader at r96 and add model.normalizeSkinWeights().The model is OK.

callmegaga on 13 Dec 2018

@mrdoob Would it be not better to call SkinnedMesh.normalizeSkinWeights() in all loaders that produce skinned meshes right now? I'm afraid we are going to have more support cases like this one...

Well, this change made me learn that models for GLTF files are supposed to have normalized skinweights so the computing would be redundant in that case. I would prefer to just fix FBXLoader instead.