Three.js: LoopRepeat executes an action once too many

[gero3]

Description of the problem

When I was writing the unit test of AnimationAction, I noticed something I didn't expect. When asking to LoopRepeat a action 3 times, it executes the action 4 times, I think.
Example: https://jsfiddle.net/wqoLka39/3/

Three.js version

• [x] Dev
• [ ] r89
• [ ] ...

Browser

• [x] All of them
• [ ] Chrome
• [ ] Firefox
• [ ] Internet Explorer

OS

• [x] All of them
• [ ] Windows
• [ ] macOS
• [ ] Linux
• [ ] Android
• [ ] iOS

Hardware Requirements (graphics card, VR Device, ...)

[mrdoob]

/ping @bhouston @tschw

[donmccurdy]

This is documented under AnimationAction.repetitions:

The number of repetitions of the performed AnimationClip over the course of this action. Can be set via setLoop. Default is Infinity.

Setting this number has no effect, if the loop mode is set to THREE.LoopOnce.

Note: The first run is not taken into account. For example: if repetition is set to 2, the total number of executed rounds will be 3.

[donmccurdy]

^I've been surprised by that as well. Not sure if there's another way to configure the action that would feel more intuitive, or if this is derived from another tool like Unity?

[bhouston]

This is confusing. We should just change the behavior to be what everyone
expects.

Best regards,
Ben Houston
http://Clara.io Online 3d modeling and rendering

On Jan 1, 2018 11:43 AM, "Don McCurdy" [e-mail] wrote:

^I've been surprised by that as well. Not sure if there's another way to
phrase the API that would feel more intuitive.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/mrdoob/three.js/issues/13011#issuecomment-354662826,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAj6_cxgg6NPY_4Ed9ZISd6eUDz1LSKJks5tGQsYgaJpZM4RQDqZ
.

[gero3]

I agree.