Themekit: Themekit modify my config directory

Created on 20 Mar 2019  路  5Comments  路  Source: Shopify/themekit

Describe the bug
When i execute "theme get -e dev" themekit rewrite my config.yml directory setting relative path with an absolute path. This behaviour make impossible to share my config with other user.

To Reproduce
Steps to reproduce the behavior:

  1. Set relative directory in config.yml (Es. directory: prod)
  2. Execute "theme watch -e prod"
  3. You'll find something like this: directory: /Users/someUser/Documents/Shopify/someStore/prod

Expected behavior
The line directory in the config.yml should remain unmodified.

Environment (please complete the following information):

  • OS: macOS Mojave vers.10.14.3

    • Themekit version: v1.0.0

  • Editor: shell
  • Ignore:
pending next release

All 5 comments

If want to specify a directory then you should specify it with the --dir flag, theme get assumes that you are creating a new theme in that environment so it will use all the config you pass into the command to write to your config file. Otherwise it will use default settings.

Oh I see the problem now, I am saving absolute paths, sorry about the confusion. I can fix that! Thanks for the report!

Okay, I have merged a fix into master, this fix will be in the v1.0.1 release.

Great great job!

1.0.1 has been released today and this was fixed in that release

Was this page helpful?
0 / 5 - 0 ratings

Related issues

amit0001 picture amit0001  路  3Comments

DanPete picture DanPete  路  4Comments

tbeseda picture tbeseda  路  3Comments

mcpatten picture mcpatten  路  12Comments

ingueferroque picture ingueferroque  路  6Comments