Theme-ui: bugs from development docs

Created on 30 Nov 2020  路  7Comments  路  Source: system-ui/theme-ui
  1. It seems that something (#1273?) broke how variants compose with mdx styles, what's visible in docs home page.
  2. Did @theme-ui/prism stop working or did we break something in the docs?
bug
Source
picture hasparus

All 7 comments

for context:

image

image

lachlanjc picture lachlanjc on 1 Dec 2020

I'll take a look tonight, seems something is off

atanasster picture atanasster on 1 Dec 2020
❤1

@hasparus - was there something else besides the Prism code highlighting?

atanasster picture atanasster on 1 Dec 2020

There are link buttons on home page.
image
image

I fiddled with it for a while, but this is quite tricky. The color from variant should override color from anchor styles.

hasparus picture hasparus on 1 Dec 2020

Thanks @hasparus - the order for variant sx props is now preserved, and the issue seems fixed

atanasster picture atanasster on 2 Dec 2020
❤1

1326 and #1320 should close this issue

atanasster picture atanasster on 2 Dec 2020

Down to 75 issues!! Hurray!

lachlanjc picture lachlanjc on 2 Dec 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

muhajirdev picture muhajirdev  路  3Comments
chibicode picture chibicode  路  3Comments
folz picture folz  路  3Comments
VinSpee picture VinSpee  路  3Comments
Everspace picture Everspace  路  3Comments