Thelounge: Insert space after channel completion

[paride]

It would be nice if the nick completion inserted a comma and space (nick,) if the completion happens at the beginning of a message, and a space if the completion happens within a message. #channel completions should also add a space after the completed channel name.

[MaxLeiter]

You can achieve the nickname part of this by adding a comma and a space to the nick autocomplete postfix in the client settings (gear icon in the bottom left)

[fnutt]

https://github.com/thelounge/thelounge/pull/1799 added this to TheLounge. Be sure to use 2.7.0 or newer version, and click on advanced settings to see it.

[McInkay]

Oh, you also mentioned after #channel completion. I'll reopen and we can discuss that.

[fnutt]

When would you want a space after channel name? huh..?

[McInkay]

When typing something after it?

[fnutt]

Seems a bit random to have space only after channel name? Would this be for writing commands only?

Here are some examples of situations where you would not need or want space:

• /join #testchannel
• /sajoin testuser #testchannel
• Something bad happening in #testchannel. Can you please have a look?
• Let's join #testchannel!

[McInkay]

Euch this is going to be configurable again isn't it?

Time to shut it down.

[paride]

First of all thanks for the very quick feedback! Having a space after the channel name could not be a good idea, after all.

[McInkay]

Cool, that's fine, I'll close the issue then.

Maybe this setting shouldn't be in advanced settings?

[paride]

@McInkay in my opinion it is fine in advanced settings, but it should default to ,␣. But I guess it's a matter of personal taste.

[McInkay]

Yeah, we had quite a lot of discussion about what it should default to ... and ended up with it defaulting to ... well nothing. But ... ach well.

Maybe it should default to a space? Is that better than defualting to nothing?

[paride]

Personally: I would prefer a space to nothing.

[MaxLeiter]

I would prefer not defaulting to anything, as I occasionally wrap channels in parenthesis (go check #thelounge)