Theia: Icons not based on file extension when file name contain "config"

[amiramw]

Bug Description:

It seems that files with the text 'config' in their name gets special icon regardless of their suffix. For what it worth this does not happen on VS Code

Steps to Reproduce:

Create two files in project:

1. gggconfig12.hdbvirtualtable
2. ggg12.hdbvirtualtable

Expection: Both should have the same icon
Actual: They have different icons in explorer.

In theia:

In vscode:

Additional Information

• Operating System: Windows
• Theia Version: master

[vince-fugnitto]

@amiramw it is not truly a fair comparison (between theia and vscode) since you are not comparing with the same file-icon theme in both instances. This is what is seen when using seti (the default icon theme for vscode):

| Theia (Default Theme) | Theia (Seti Theme) |
|:---:|:---:|
| | |

We get the icons from file-icons.js, you can see why config files are displayed this way:

• https://github.com/websemantics/file-icons-js/blob/9ceebffdefe63be331cb5d073b5761423655ac4c/index.js#L1374

[akosyakov]

So no fix? One has to use seti theme as default?

[kittaakos]

We get the icons from file-icons.js, you can see why config files are displayed this way:

• https://github.com/websemantics/file-icons-js/blob/9ceebffdefe63be331cb5d073b5761423655ac4c/index.js#L1374

This. I confirm.

So no fix?

Once I had to introduce a custom WorkspaceUriLabelProviderContribution as a workaround in a downstream project, just because of the config part in the file name pulled in the config icon. I have not found a better fix at that time.

[vince-fugnitto]

I've been wondering if we should have a better default file-icon theme as file-icons.js is not actively maintained (last release was over 3 years ago).

The alternative would be to fork the repo under theiaide and perform minor maintenance on it (such as customizing when the config icon is used), and perform releases to npm.

[akosyakov]

have a better default file-icon theme

Do you have anything in mind?

[vince-fugnitto]

have a better default file-icon theme

Do you have anything in mind?

I could not find anything quickly to suit our needs, perhaps forking would be sufficient at the moment (and not require changes to the codebase).

[kittaakos]

@Kreyren wrote here:

Transfer from gitpod-io/gitpod#1570 as requested by @akosyakov

[kittaakos]

It's not a Theia issue. Closing.