Theia: TypeError: Cannot read property 'items' of undefined when selecting "Find All implementations"

[lmcbout]

Bug Description:

Selecting in the context menu -> Find All implementations
generates the following error:

root ERROR [hosted-plugin: 29023] Promise rejection not handled in one second: **TypeError: Cannot read property 'items' of undefined** , reason: TypeError: Cannot read property 'items' of undefined
root ERROR [hosted-plugin: 29023] With stack trace: TypeError: Cannot read property 'items' of undefined
    at g (/home/lmcbout/theia/theia/plugins/vscode-references-view/extension/dist/extension.js:1:8294)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Steps to Reproduce:

1. Open Theia, select a file (quick-view-service.ts)
2. From the context menu, select "Find All Implementations"
   --> Observe on the console, the error is reported

Additional Information

• Operating System: Ubuntu 18.04
• Theia Version: Latest
• Builtin versions: 139.1 and 144.2

[vince-fugnitto]

@lmcbout the command still works correctly for me (it displays the implementations), is the same case for you?

1. open quick-view-service.ts
2. highlight QuickOpenModel
3. execute the command 'Find All Implementations'

[lmcbout]

@vince-fugnitto Yes, it display some information, but there is still the error log on the console. The priority to fix it is low since it returns some data

[vince-fugnitto]

@vince-fugnitto Yes, it display some information, but there is still the error log on the console. The priority to fix it is low since it returns some data

It looks like it still works, I’m not sure when the error is reported it is likely only when there are no implementations available. The logging should not be harmful.

[akosyakov]

Getting rid of such logging is good as well, plus sometimes it reveals some incompatibilities to support VS Code extensions, then it should be fixed.

[vince-fugnitto]

I cannot reproduce the error on the console any longer, the find all implementations functionality still works correctly.