Description
Support Timeline API (beta now).
Reproduction Steps
VS Code Insiders has a proposed API for timelines. this extension can be used for testing .
Maybe this API can only be implemented when VS Code adds it into stable.
OS and Theia version:
Any
Diagnostics:
No
sh7dm
All 9 comments
We have to implement the widget first in @theia/scm after that connect it with VS Code APIs in @theia/plugin-ext.
akosyakov
on 15 Apr 2020
@akosyakov it shouldn't be bound to scm, maybe another extension is required.
sh7dm
on 16 Apr 2020
ok, something like @theia/timeline sounds good as well.
akosyakov
on 16 Apr 2020
Great! Not only SCMs can provide timeline data. I think this extension should provide both Theia internal API for extensions to connect to as well as VS Code compliant API for plugins, is this correct? Or only VS Code API will be enough?
sh7dm
on 16 Apr 2020
@theia/timeline should provide API for extensions it is correct, wiring to VS Code API should be done in @theia/plugin-ext. APIs should be aligned though.
akosyakov
on 16 Apr 2020
As I've seen from VS Code source, only APIs for Timelines are types and workspace.registerTimelineProvider.
sh7dm
on 16 Apr 2020
@akosyakov Looks like existing History View is good for it, maybe with some changes.
sh7dm
on 18 Apr 2020
@sh7dm Yes, it could be used as the basis. @westbury would it be fine?
akosyakov
on 20 Apr 2020
TODO for converting History to Timeline (@ maintainers feel free to update):
- [ ] Add icons support
- [ ] Add VS Code compatible API
More actions me be required too.
sh7dm
on 20 Apr 2020
Related issues
akosyakov
路
3Comments
jeanlucburot
路
3Comments
kpge
路
3Comments
kittaakos
路
3Comments
Beetix
路
3Comments
Most helpful comment
As I've seen from VS Code source, only APIs for Timelines are types and
workspace.registerTimelineProvider.