Theia: Recently used commands include ones triggered by mouse

Created on 8 Apr 2020  路  3Comments  路  Source: eclipse-theia/theia

Description

I expect commands triggered from UI or by keyboard not to be added to recent commands list, just as in VS Code. Theia does so. If this is expected, it'll be nice to have a setting for that.

Reproduction Steps

A (Theia):

  1. Click notifications bell
  2. Press F1 and see that it was added to recent commands list
    B (VS Code)
  3. Click notifications bell
  4. Press F1 and see that it was __NOT__ added to recent commands list. Recent list contains only commands that were triggered from F1/Ctrl+Shift+P menu.

OS and Theia version:
Ubuntu 19.10
Theia 1.0.0 (master)

Diagnostics:

No errors

commands help wanted

All 3 comments

@sh7dm you're right, at the moment the framework makes no distinction on how a command was executed, meaning that it will register a recent command whenever a command is executed:

  • through the quick-open command menu (vscode use-case)
  • through manual selection by a user
  • through it's keybinding value (if present)

Would you like to handle fixing the issue, meaning only registering commands in the quick-open if it's triggered by the first use-case?

Would like to try myself on it!

Would like to try myself on it!

Great! Please let us know if you're having difficulties or are blocked in any way :)

Was this page helpful?
0 / 5 - 0 ratings