Theia: tree-view: update styling when the tree row content cannot be fully displayed

[vince-fugnitto]

Description

The styling of tree-view components (ex: 'npm scripts') should be updated so we are consistent with the rest of the application.

Namely, when a tree-view row's content cannot be fully displayed, the row should display ellipsis like other trees in the application. At the moment, the styling is inconsistent:

Additional Information

Related Pull-Requests:

• https://github.com/eclipse-theia/theia/pull/7124
• https://github.com/eclipse-theia/theia/pull/6939

[garethwhittaker]

Hi @vince-fugnitto.

I don't see this issue in Gitpod. I've taken a screenshot showing the ellipsis being applied.
Notably the spanner icon for npm scripts is also different.

[vince-fugnitto]

Hi @vince-fugnitto.

I don't see this issue in Gitpod. I've taken a screenshot showing the ellipsis being applied.
Notably the spanner icon for npm scripts is also different.

Hi @garethwhittaker, in your screenshot, are you displaying Gitpod itself or simply using Gitpod to open Theia? If it’s the former, it’s possible that Gitpod is using an older version of Theia that does not have this regression.

[vince-fugnitto]

@garethwhittaker I've verified again with master:

The fix was initially present as part of #6939 but due to other issues it was reverted as part of #7124. #7124 fixed some problems with how other plugin views were displayed at the expense that rows present in tree-views did not successfully display ellipsis when their content could not be displayed entirely.

[garethwhittaker]

Yes you're right @vince-fugnitto. Whilst the issue doesn't appear in Gitpod, it does when using Gitpod to view latest Theia.

I can take a look at resolving this regression and provide an update in the next week.

[vince-fugnitto]

I can take a look at resolving this regression and provide an update in the next week.

Sure! That'd be great, please keep #7124 in mind during your updates, other plugin views (such as gitlens) should be displayed correctly as well.

[vince-fugnitto]

Closed by #7237