Theia: a breakpoint becomes inline after line copying

[tom-shan]

Description

Reproduction Steps

OS and Theia version:
OS: centos 7
Theia: d5f32625017a6ea38bc2a6bcdd0060ec8a92ab9c

Diagnostics:

[akosyakov]

@tom-shan Do you have active debug session?

[tom-shan]

@tom-shan Do you have active debug session?

no active debug session

[justinang1]

Would like to look into this issue, but I'm unsure of which files to look into to get started. I'm thinking that this issue is probably caused by the editor window and the handler for the copy command, any pointers on which files these components would be under?

I also believe this issue might be related to #6910.

[akosyakov]

Breakpoints are updated here: https://github.com/eclipse-theia/theia/blob/master/packages/debug/src/browser/editor/debug-editor-model.ts#L227

[tom-shan]

Breakpoints are updated here: https://github.com/eclipse-theia/theia/blob/master/packages/debug/src/browser/editor/debug-editor-model.ts#L227

if column number is 1, will it be an inline breakpoint? if the answer is no, maybe we should change the condition to typeof column === 'number' && column > 1

[akosyakov]

@tom-shan Could you send a PR please? let's try your approach

[akosyakov]

Maybe https://github.com/eclipse-theia/theia/issues/6910 is another issue which will be get fixed by such PR.

[justinang1]

I was testing the same approach as @tom-shan. Breakpoints are initialized with column undefined but when copied, the column becomes 1. I was going to do more testing and create a PR by the end of today.